RESOLVED FIXED 154504
Make HTMLSelectElement.size behave as per the specification
https://bugs.webkit.org/show_bug.cgi?id=154504
Summary Make HTMLSelectElement.size behave as per the specification
Chris Dumez
Reported 2016-02-20 13:31:12 PST
Make HTMLSelectElement behave as per the specification: - https://html.spec.whatwg.org/#dom-select-size - https://html.spec.whatwg.org/#reflecting-content-attributes-in-idl-attributes:idl-unsigned-long In particular, it should be unsigned and be in the range [0; 2147483647]. Also update several unsigned long attributes in our HTML implementation to use parseHTMLNonNegativeInteger() to parse the unsigned integer as per the HTML specification, instead of calling String::toUint().
Attachments
Patch (80.54 KB, patch)
2016-02-20 14:05 PST, Chris Dumez
no flags
Patch (76.58 KB, patch)
2016-02-21 21:50 PST, Chris Dumez
no flags
Chris Dumez
Comment 1 2016-02-20 14:05:02 PST
Darin Adler
Comment 2 2016-02-21 16:46:07 PST
Comment on attachment 271871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271871&action=review > Source/WebCore/html/HTMLSelectElement.idl:35 > +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > + attribute unsigned long size; > +#else > attribute long size; > +#endif Since the non-unsigned thing is only there for backward compatibility, I would prefer it if that side was the one that listed languages (Objective-C, GObject bindings). > LayoutTests/ChangeLog:20 > + * fast/forms/select-size.html: > + * platform/mac/fast/forms/select-size-expected.png: > + * platform/mac/fast/forms/select-size-expected.txt: Can we change this into a reference test? It seems like a natural for that.
Chris Dumez
Comment 3 2016-02-21 21:50:58 PST
Chris Dumez
Comment 4 2016-02-21 21:52:06 PST
Comment on attachment 271902 [details] Patch Clearing flags on attachment: 271902 Committed r196893: <http://trac.webkit.org/changeset/196893>
Chris Dumez
Comment 5 2016-02-21 21:52:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.