Bug 154504 – Make HTMLSelectElement.size behave as per the specification

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Make HTMLSelectElement behave as per the specification:
- https://html.spec.whatwg.org/#dom-select-size
- https://html.spec.whatwg.org/#reflecting-content-attributes-in-idl-attributes:idl-unsigned-long

In particular, it should be unsigned and be in the range [0; 2147483647].

Also update several unsigned long attributes in our HTML implementation to use parseHTMLNonNegativeInteger() to parse the unsigned integer as per the HTML specification, instead of calling String::toUint().

[Chris Dumez]

Created attachment 271871 [details]
Patch

[Darin Adler]

Comment on attachment 271871 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271871&action=review

> Source/WebCore/html/HTMLSelectElement.idl:35
> +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +    attribute unsigned long size;
> +#else
>      attribute long size;
> +#endif

Since the non-unsigned thing is only there for backward compatibility, I would prefer it if that side was the one that listed languages (Objective-C, GObject bindings).

> LayoutTests/ChangeLog:20
> +        * fast/forms/select-size.html:
> +        * platform/mac/fast/forms/select-size-expected.png:
> +        * platform/mac/fast/forms/select-size-expected.txt:

Can we change this into a reference test? It seems like a natural for that.

[Chris Dumez]

Created attachment 271902 [details]
Patch

[Chris Dumez]

Comment on attachment 271902 [details]
Patch

Clearing flags on attachment: 271902

Committed r196893: <http://trac.webkit.org/changeset/196893>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.