Bug 154498 - Enhance logging: Add "always on" macros
Summary: Enhance logging: Add "always on" macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks: 154499
  Show dependency treegraph
 
Reported: 2016-02-20 11:49 PST by Keith Rollin
Modified: 2016-02-26 15:33 PST (History)
6 users (show)

See Also:


Attachments
Patch (deleted)
2016-02-23 13:57 PST, Keith Rollin
no flags Details
Patch (3.69 KB, patch)
2016-02-26 10:45 PST, Keith Rollin
no flags Details | Formatted Diff | Diff
Patch (3.85 KB, patch)
2016-02-26 13:02 PST, Keith Rollin
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-yosemite (853.61 KB, application/zip)
2016-02-26 14:20 PST, Build Bot
no flags Details
Patch (3.85 KB, patch)
2016-02-26 14:33 PST, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2016-02-20 11:49:46 PST
Add macros to Assertions.h/.cpp to be used for "always on" logging. This is logging that we want in both debug and release code, the former for development purposes, the latter so that we can capture information to help diagnose issues that occur on customers' systems.
Comment 1 Radar WebKit Bug Importer 2016-02-20 11:59:57 PST
<rdar://problem/24757759>
Comment 2 Keith Rollin 2016-02-23 13:57:53 PST
Created attachment 272051 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2016-02-24 16:30:21 PST
The content of attachment 272051 [details] has been deleted by
    David Kilzer (:ddkilzer) <ddkilzer@webkit.org>
who provided the following reason:

Yes

The token used to delete this attachment was generated at 2016-02-24 16:30:04 PST.
Comment 4 Keith Rollin 2016-02-26 10:45:51 PST
Created attachment 272338 [details]
Patch
Comment 5 Chris Dumez 2016-02-26 10:50:12 PST
Comment on attachment 272338 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272338&action=review

> Source/WTF/wtf/Assertions.h:388
> +#define LOG_ALWAYS_ERROR(format, ...) WTFLogAlways(format, ##__VA_ARGS__)

Shouldn't this do something similar to LOG_ERROR?
Comment 6 Keith Rollin 2016-02-26 13:02:41 PST
Created attachment 272361 [details]
Patch
Comment 7 Build Bot 2016-02-26 14:20:44 PST
Comment on attachment 272361 [details]
Patch

Attachment 272361 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/887355

New failing tests:
storage/indexeddb/odd-strings-private.html
Comment 8 Build Bot 2016-02-26 14:20:47 PST
Created attachment 272372 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Chris Dumez 2016-02-26 14:22:40 PST
Comment on attachment 272361 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2016-02-26 14:24:29 PST
Comment on attachment 272361 [details]
Patch

Rejecting attachment 272361 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 272361, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/887543
Comment 11 Chris Dumez 2016-02-26 14:26:47 PST
Comment on attachment 272361 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272361&action=review

> Source/WTF/ChangeLog:7
> +        Reviewed by NOBODY (OOPS).

Isn't supposed to be (OOPS!)??
Comment 12 Keith Rollin 2016-02-26 14:33:08 PST
Created attachment 272373 [details]
Patch
Comment 13 WebKit Commit Bot 2016-02-26 15:33:39 PST
Comment on attachment 272373 [details]
Patch

Clearing flags on attachment: 272373

Committed r197214: <http://trac.webkit.org/changeset/197214>
Comment 14 WebKit Commit Bot 2016-02-26 15:33:44 PST
All reviewed patches have been landed.  Closing bug.