Bug 154491 - Web Inspector: Visual Styles: Modifying background expands Font section
Summary: Web Inspector: Visual Styles: Modifying background expands Font section
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-19 21:26 PST by Nikita Vasilyev
Modified: 2016-02-20 14:47 PST (History)
9 users (show)

See Also:

Attachments
[Animated GIF] Bug (100.97 KB, image/gif)
2016-02-19 21:26 PST, Nikita Vasilyev 		no flags Details
Patch (9.89 KB, patch)
2016-02-20 03:59 PST, Devin Rousso 		timothy: review+
Details | Formatted Diff | Diff
Patch (9.75 KB, patch)
2016-02-20 13:49 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-02-19 21:26:42 PST 
Created attachment 271844 [details]
[Animated GIF] Bug

Modifying one visual-style-property-value-container causes another one to expand.
See the attached GIF.
Comment 1 Radar WebKit Bug Importer 2016-02-19 21:26:58 PST 
<rdar://problem/24755440>
Comment 2 Devin Rousso 2016-02-20 03:59:14 PST 
Created attachment 271858 [details]
Patch
Comment 3 Timothy Hatcher 2016-02-20 09:27:04 PST 
Comment on attachment 271858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271858&action=review

> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:180
>                      }
> +                    if (styleFound)

Newline between lines line this.
Comment 4 Timothy Hatcher 2016-02-20 09:29:56 PST 
Comment on attachment 271858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271858&action=review

>> Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js:180
>> +                    if (styleFound)
> 
> Newline between lines line this.

…lines like this.
Comment 5 Devin Rousso 2016-02-20 13:49:40 PST 
Created attachment 271869 [details]
Patch
Comment 6 WebKit Commit Bot 2016-02-20 14:47:48 PST 
Comment on attachment 271869 [details]
Patch

Clearing flags on attachment: 271869

Committed r196867: <http://trac.webkit.org/changeset/196867>
Comment 7 WebKit Commit Bot 2016-02-20 14:47:54 PST 
All reviewed patches have been landed.  Closing bug.