Bug 154488 - Web Inspector: Placeholder text in Visual Styles sidebar table row should be white
Summary: Web Inspector: Placeholder text in Visual Styles sidebar table row should be ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-19 18:51 PST by Timothy Hatcher
Modified: 2016-02-20 00:40 PST (History)
8 users (show)

See Also:


Attachments
Screenshot of the Bug (45.86 KB, image/png)
2016-02-19 18:51 PST, Timothy Hatcher
no flags Details
Patch (2.01 KB, patch)
2016-02-19 21:58 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Image] With the patch applied (8.08 KB, image/png)
2016-02-19 21:59 PST, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-02-19 18:51:59 PST
Created attachment 271837 [details]
Screenshot of the Bug

The placeholder text is gray and hard to read. It should be a transparent white (rgba(255, 255, 255, 0.8)) when selected and focused to stand out on the blue row background.
Comment 1 Radar WebKit Bug Importer 2016-02-19 18:52:20 PST
<rdar://problem/24754715>
Comment 2 Nikita Vasilyev 2016-02-19 21:14:03 PST
I don't quite understand this placeholder text:

> (modify the boxes below to add a value)

Which boxes? Why do I need to modify them if I can
just click on the placeholder and enter "fantasy"?

I suggest:
1. To make placeholder text gray on a transparent background.
2. Replace the text with the computed (i.e. inherited) font-family
   value.
Comment 3 Nikita Vasilyev 2016-02-19 21:20:41 PST
(In reply to comment #2)
> I don't quite understand this placeholder text:
> 
> > (modify the boxes below to add a value)
> 
> Which boxes? Why do I need to modify them if I can
> just click on the placeholder and enter "fantasy"?

I see, this placeholder text makes sense for Background -> Style
and Background -> Box Shadow.
Comment 4 Nikita Vasilyev 2016-02-19 21:58:08 PST
Created attachment 271846 [details]
Patch

I set the placeholder color to be semi-transparent white
to make it distinguishable from user entered values, which
are just white.
Comment 5 Nikita Vasilyev 2016-02-19 21:59:00 PST
Created attachment 271847 [details]
[Image] With the patch applied
Comment 6 Nikita Vasilyev 2016-02-19 22:03:54 PST
(In reply to comment #0)
> Created attachment 271837 [details]
> Screenshot of the Bug
> 
> The placeholder text is gray and hard to read. It should be a transparent
> white (rgba(255, 255, 255, 0.8)) when selected and focused to stand out on
> the blue row background.

Whoops, I set the alpha channel to 0.7 and not 0.8.
Do we use 0.8 value somewhere else?
Comment 7 WebKit Commit Bot 2016-02-20 00:40:36 PST
Comment on attachment 271846 [details]
Patch

Clearing flags on attachment: 271846

Committed r196857: <http://trac.webkit.org/changeset/196857>
Comment 8 WebKit Commit Bot 2016-02-20 00:40:40 PST
All reviewed patches have been landed.  Closing bug.