RESOLVED FIXED Bug 154488
Web Inspector: Placeholder text in Visual Styles sidebar table row should be white
https://bugs.webkit.org/show_bug.cgi?id=154488
Summary Web Inspector: Placeholder text in Visual Styles sidebar table row should be ...
Timothy Hatcher
Reported 2016-02-19 18:51:59 PST
Created attachment 271837 [details] Screenshot of the Bug The placeholder text is gray and hard to read. It should be a transparent white (rgba(255, 255, 255, 0.8)) when selected and focused to stand out on the blue row background.
Attachments
Screenshot of the Bug (45.86 KB, image/png)
2016-02-19 18:51 PST, Timothy Hatcher
no flags
Patch (2.01 KB, patch)
2016-02-19 21:58 PST, Nikita Vasilyev
no flags
[Image] With the patch applied (8.08 KB, image/png)
2016-02-19 21:59 PST, Nikita Vasilyev
no flags
Radar WebKit Bug Importer
Comment 1 2016-02-19 18:52:20 PST
Nikita Vasilyev
Comment 2 2016-02-19 21:14:03 PST
I don't quite understand this placeholder text: > (modify the boxes below to add a value) Which boxes? Why do I need to modify them if I can just click on the placeholder and enter "fantasy"? I suggest: 1. To make placeholder text gray on a transparent background. 2. Replace the text with the computed (i.e. inherited) font-family value.
Nikita Vasilyev
Comment 3 2016-02-19 21:20:41 PST
(In reply to comment #2) > I don't quite understand this placeholder text: > > > (modify the boxes below to add a value) > > Which boxes? Why do I need to modify them if I can > just click on the placeholder and enter "fantasy"? I see, this placeholder text makes sense for Background -> Style and Background -> Box Shadow.
Nikita Vasilyev
Comment 4 2016-02-19 21:58:08 PST
Created attachment 271846 [details] Patch I set the placeholder color to be semi-transparent white to make it distinguishable from user entered values, which are just white.
Nikita Vasilyev
Comment 5 2016-02-19 21:59:00 PST
Created attachment 271847 [details] [Image] With the patch applied
Nikita Vasilyev
Comment 6 2016-02-19 22:03:54 PST
(In reply to comment #0) > Created attachment 271837 [details] > Screenshot of the Bug > > The placeholder text is gray and hard to read. It should be a transparent > white (rgba(255, 255, 255, 0.8)) when selected and focused to stand out on > the blue row background. Whoops, I set the alpha channel to 0.7 and not 0.8. Do we use 0.8 value somewhere else?
WebKit Commit Bot
Comment 7 2016-02-20 00:40:36 PST
Comment on attachment 271846 [details] Patch Clearing flags on attachment: 271846 Committed r196857: <http://trac.webkit.org/changeset/196857>
WebKit Commit Bot
Comment 8 2016-02-20 00:40:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.