Bug 154483 - Do not require UDate in LocaleICU with !ENABLE_DATE_AND_TIME_INPUT_TYPES
Summary: Do not require UDate in LocaleICU with !ENABLE_DATE_AND_TIME_INPUT_TYPES
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2016-02-19 17:07 PST by Olivier Blin
Modified: 2016-02-20 08:42 PST (History)
6 users (show)

See Also:

Patch (5.29 KB, patch)
2016-02-19 17:09 PST, Olivier Blin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2016-02-19 17:07:13 PST
initializeShortDateFormat(), dateFormat(), m_shortDateFormat and m_didCreateShortDateFormat should be moved under flag, since they are only used by code under the ENABLE_DATE_AND_TIME_INPUT_TYPES flag.
This helps to build with a light ICU that does not provide UDate features (with UCONFIG_NO_FORMATTING).
Comment 1 Olivier Blin 2016-02-19 17:09:10 PST
Created attachment 271829 [details]
Comment 2 Michael Catanzaro 2016-02-20 07:53:38 PST
Comment on attachment 271829 [details]

I guess it's right; I looked in bug #101007 for some explanation of why short data format was not behind this flag, but couldn't find any justification for this.
Comment 3 WebKit Commit Bot 2016-02-20 08:42:21 PST
Comment on attachment 271829 [details]

Clearing flags on attachment: 271829

Committed r196861: <http://trac.webkit.org/changeset/196861>
Comment 4 WebKit Commit Bot 2016-02-20 08:42:26 PST
All reviewed patches have been landed.  Closing bug.