Bug 154471 - Web Inspector: color swatch and border are misaligned in Visual Styles sidebar
Summary: Web Inspector: color swatch and border are misaligned in Visual Styles sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-19 14:18 PST by Timothy Hatcher
Modified: 2016-03-10 17:03 PST (History)
9 users (show)

See Also:

Attachments
Screenshot of the Bug (11.44 KB, image/png)
2016-02-19 14:18 PST, Timothy Hatcher 		no flags Details
Patch (2.63 KB, patch)
2016-03-09 16:37 PST, Daniel Strokis 		no flags Details | Formatted Diff | Diff
[image] Left corners rounded (307.98 KB, image/png)
2016-03-09 17:20 PST, Matt Baker 		no flags Details
Patch (2.43 KB, patch)
2016-03-10 15:06 PST, Daniel Strokis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-02-19 14:18:52 PST 
Created attachment 271799 [details]
Screenshot of the Bug

Steps:
1) Open Visual Styles sidebar
2) Show Text > Style section
3) Resize sidebar, and notice the border shifts on the swatch

Results: Border shifts depending on the switch of the sidebar
Expected: Border stays in the same position always

Note: This could be a WebKit bug or a sub-pixel layout issues we need to workaround.
Comment 1 Radar WebKit Bug Importer 2016-02-19 14:19:29 PST 
<rdar://problem/24749596>
Comment 2 Timothy Hatcher 2016-02-19 14:20:01 PST 
See bug 148106 for my original report of this.
Comment 3 Daniel Strokis 2016-03-09 16:37:11 PST 
Created attachment 273508 [details]
Patch
Comment 4 Matt Baker 2016-03-09 17:20:34 PST 
Created attachment 273514 [details]
[image] Left corners rounded

Looking good. One suggestion: what if we tried applying the radius to just the left corners?
Comment 5 Daniel Strokis 2016-03-09 17:34:00 PST 
That would look consistent with the other swatches & buttons in the Inspector, which I think looks good.
Comment 6 Timothy Hatcher 2016-03-09 20:39:12 PST 
(In reply to comment #4)
> Created attachment 273514 [details]
> [image] Left corners rounded
> 
> Looking good. One suggestion: what if we tried applying the radius to just
> the left corners?

I like it left-side only.
Comment 7 Daniel Strokis 2016-03-10 15:06:00 PST 
Created attachment 273629 [details]
Patch
Comment 8 WebKit Commit Bot 2016-03-10 17:03:28 PST 
Comment on attachment 273629 [details]
Patch

Clearing flags on attachment: 273629

Committed r197975: <http://trac.webkit.org/changeset/197975>
Comment 9 WebKit Commit Bot 2016-03-10 17:03:32 PST 
All reviewed patches have been landed.  Closing bug.