Bug 154464 - ComposedTreeIterator traverses normal children for elements with empty shadow root
Summary: ComposedTreeIterator traverses normal children for elements with empty shadow...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 154355
  Show dependency treegraph
 
Reported: 2016-02-19 12:07 PST by Antti Koivisto
Modified: 2016-02-19 15:31 PST (History)
1 user (show)

See Also:


Attachments
patch (10.42 KB, patch)
2016-02-19 12:32 PST, Antti Koivisto
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-02-19 12:07:39 PST
It shouldn't do that.
Comment 1 Antti Koivisto 2016-02-19 12:32:24 PST
Created attachment 271778 [details]
patch
Comment 2 Ryosuke Niwa 2016-02-19 13:08:48 PST
Comment on attachment 271778 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271778&action=review

> Source/WebCore/dom/ComposedTreeIterator.h:58
> +    void dropAssertions();
> +

I understand this is needed for the bug 154355 but can land it there instead?
Comment 3 Antti Koivisto 2016-02-19 15:31:23 PST
http://trac.webkit.org/changeset/196833