154461 – Web Inspector: Inspector creates thousands of page groups

Bug 154461 - Web Inspector: Inspector creates thousands of page groups

Summary: Web Inspector: Inspector creates thousands of page groups

Status:	RESOLVED INVALID

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Local Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2016-02-19 09:54 PST by Timothy Hatcher
Modified:	2016-02-19 10:22 PST (History)
CC List:	7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Timothy Hatcher 2016-02-19 09:54:59 PST

Looking at my user defaults, I noticed a bug where we make a new page group identifier almost every time.

This code seems like the culprit:

unsigned WebInspectorProxy::inspectionLevel() const
{
    auto findResult = pageLevelMap().find(inspectedPage());
    if (findResult != pageLevelMap().end())
        return findResult->value + 1;

    return 1;
}

Defaults:

    "__WebInspectorPageGroupLevel1000__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1000__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1001__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1001__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1002__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1002__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1003__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1003__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1004__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1004__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1005__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1005__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1006__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1006__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1007__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1007__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1008__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1008__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1009__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1009__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel100__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel100__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1010__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1010__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1011__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1011__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1012__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1012__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1013__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1013__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1014__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1014__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1015__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1015__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1016__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1016__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1017__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1017__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1018__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1018__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1019__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1019__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel101__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel101__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1020__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1020__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1021__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1021__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1022__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1022__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1023__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1023__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1024__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1024__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1025__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1025__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1026__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1026__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1027__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1027__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1028__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1028__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1029__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1029__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel102__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel102__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1030__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1030__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1031__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1031__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1032__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1032__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1033__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1033__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1034__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1034__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1035__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1035__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1036__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1036__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1037__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1037__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1038__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1038__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1039__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1039__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel103__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel103__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1040__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1040__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1041__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1041__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1042__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1042__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1043__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1043__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1044__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1044__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1045__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1045__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1046__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1046__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1047__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1047__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1048__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1048__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1049__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1049__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel104__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel104__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1050__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1050__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1051__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1051__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1052__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1052__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1053__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1053__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1054__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1054__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1055__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1055__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1056__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1056__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1057__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1057__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1058__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1058__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1059__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1059__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel105__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel105__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1060__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1060__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1061__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1061__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1062__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1062__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1063__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel1063__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel1064__.WebKit2AllowFileAccessFromFileURLs" = 1;

...
 
    "__WebInspectorPageGroupLevel998__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel998__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel999__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel999__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel99__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel99__.WebKit2ApplicationChromeModeEnabled" = 1;
    "__WebInspectorPageGroupLevel9__.WebKit2AllowFileAccessFromFileURLs" = 1;
    "__WebInspectorPageGroupLevel9__.WebKit2ApplicationChromeModeEnabled" = 1;

Comment 1 Radar WebKit Bug Importer 2016-02-19 09:55:19 PST

<rdar://problem/24743204>

Comment 2 Timothy Hatcher 2016-02-19 10:22:35 PST

Joe did no see similar on his machine. I deleted these and will watch to see if they come back. They could have been created by older version of the code.