Bug 154442 - Add isJSString(JSCell*) variant to avoid Cell->JSValue->Cell conversion
Summary: Add isJSString(JSCell*) variant to avoid Cell->JSValue->Cell conversion
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
Depends on:
Reported: 2016-02-18 23:46 PST by Joseph Pecoraro
Modified: 2016-02-19 02:39 PST (History)
6 users (show)

See Also:

[PATCH] Proposed Fix (1.43 KB, patch)
2016-02-18 23:47 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-02-18 23:46:54 PST
Unlike isJSArray and isJSNonFinalObject functions which have JSCell and JSValue variants, the isJSString helper only had a JSValue variant. Add the cell variant to avoid possible extra unnecessary conversions. The JSC::JSValue(JSCell*) constructor is not explicit.
Comment 1 Joseph Pecoraro 2016-02-18 23:47:33 PST
Created attachment 271739 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-02-19 02:39:31 PST
Comment on attachment 271739 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 271739

Committed r196810: <http://trac.webkit.org/changeset/196810>
Comment 3 WebKit Commit Bot 2016-02-19 02:39:35 PST
All reviewed patches have been landed.  Closing bug.