Bug 154434 - Blocked plug-in placeholder is sometimes not shown.
Summary: Blocked plug-in placeholder is sometimes not shown.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-18 21:07 PST by zalan
Modified: 2016-02-19 03:48 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.33 KB, patch)
2016-02-18 21:23 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2016-02-18 21:24 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-02-18 21:07:39 PST
1. In Safari Preferences > Security > Plug-in Settings, set Flash or Quicktime to Ask or Block
2. Go to http://www.adobe.com/software/flash/about/
3. Repeatedly reload the page
Comment 1 zalan 2016-02-18 21:08:04 PST
rdar://problem/22584973
Comment 2 zalan 2016-02-18 21:23:36 PST
Created attachment 271729 [details]
Patch
Comment 3 zalan 2016-02-18 21:24:35 PST
Created attachment 271730 [details]
Patch
Comment 4 Brent Fulgham 2016-02-18 23:29:14 PST
Comment on attachment 271730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271730&action=review

Looks good. r=me.  I do wish we had some way to test this properly.

> Source/WebCore/rendering/RenderEmbeddedObject.h:97
> +    UnavailablePluginIndicatorState m_isUnavailablePluginIndicatorState { UnavailablePluginIndicatorState::Uninitialized };

Very nice!
Comment 5 WebKit Commit Bot 2016-02-19 03:48:18 PST
Comment on attachment 271730 [details]
Patch

Clearing flags on attachment: 271730

Committed r196813: <http://trac.webkit.org/changeset/196813>
Comment 6 WebKit Commit Bot 2016-02-19 03:48:23 PST
All reviewed patches have been landed.  Closing bug.