Bug 154431 - AX: Inconsistency between CharacterOffset and VisiblePostition
Summary: AX: Inconsistency between CharacterOffset and VisiblePostition
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2016-02-18 17:45 PST by Nan Wang
Modified: 2016-02-19 10:58 PST (History)
11 users (show)

See Also:

patch (26.27 KB, patch)
2016-02-18 18:05 PST, Nan Wang
no flags Details | Formatted Diff | Diff
patch (26.40 KB, patch)
2016-02-19 08:39 PST, Nan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2016-02-18 17:45:47 PST
The previous/next text marker from CharacterOffset should be consistent with VisiblePosition so that node start and end will be included when navigating.
Comment 1 Radar WebKit Bug Importer 2016-02-18 17:47:25 PST
Comment 2 Nan Wang 2016-02-18 18:05:53 PST
Created attachment 271720 [details]
Comment 3 chris fleizach 2016-02-19 00:01:36 PST
Comment on attachment 271720 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=271720&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1866
> +        // When VisiblePostion move to next node, it will count the leading line break as

"moves" to the next node

> Source/WebCore/accessibility/AXObjectCache.h:-199
> -    CharacterOffset nextCharacterOffset(const CharacterOffset&, bool ignoreStart = true);

it's not clear what ignoreStart/ignorePrevEnd means here. can you add a comment or rename this param?
Comment 4 Nan Wang 2016-02-19 08:39:07 PST
Created attachment 271755 [details]
Comment 5 WebKit Commit Bot 2016-02-19 10:58:29 PST
Comment on attachment 271755 [details]

Clearing flags on attachment: 271755

Committed r196824: <http://trac.webkit.org/changeset/196824>
Comment 6 WebKit Commit Bot 2016-02-19 10:58:33 PST
All reviewed patches have been landed.  Closing bug.