Bug 154424 – Enhance EditorState to include TypingAttributes, alignment, and color

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

Enhance EditorState to include TypingAttributes, alignment, and color

[Beth Dakin]

Created attachment 271713 [details]
Patch

[Dean Jackson]

Comment on attachment 271713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271713&action=review

> Source/WebKit2/Shared/EditorState.h:48
> +enum TextAlignment {

enum class?

[Sam Weinig]

Comment on attachment 271713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271713&action=review

> Source/WebKit2/Shared/EditorState.h:95
> +        WebCore::Color textColor { WebCore::Color::black };

Since not every platform has these implemented, should they remain enabled? Can we refactor at all to make these supported on all platforms?

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:160
> +        if (RenderStyle* style = Editor::styleForSelectionStart(&frame, nodeToRemove)) {
> +            NSFont *font = style->fontCascade().primaryFont().getNSFont();
> +            NSFontTraitMask traits = [[NSFontManager sharedFontManager] traitsOfFont:font];
> +
> +            if (traits & NSBoldFontMask)
> +                postLayoutData.typingAttributes |= AttributeBold;
> +            if (traits & NSItalicFontMask)
> +                postLayoutData.typingAttributes |= AttributeItalics;
> +            

Can this be done by doing:

if (style->fontCascade().weight() == FontWeightBold)
    postLayoutData.typingAttributes |= AttributeBold;
if (style->fontCascade().italic() == FontItalicOn)
    postLayoutData.typingAttributes |= AttributeItalics;

or 

just look at the style itself?

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:200
> +                nodeToRemove->remove(ASSERT_NO_EXCEPTION);
> +        }

Can any of this be shared across Mac and iOS?

[Beth Dakin]

Thanks Sam and Dean! http://trac.webkit.org/changeset/196834