Bug 15442 - Cease "hacking" the scope chains of nested functions
Summary: Cease "hacking" the scope chains of nested functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: 14868
  Show dependency tree / graph
 
Reported: 2007-10-09 15:03 PDT by Geoffrey Garen
Modified: 2007-10-15 13:54 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.47 KB, patch)
2007-10-09 15:04 PDT, Geoffrey Garen 		darin: review+
Details | Formatted Diff | Diff
Patch2 (6.71 KB, patch)
2007-10-09 15:10 PDT, Geoffrey Garen 		darin: review+
Details | Formatted Diff | Diff
Patch3 (6.76 KB, patch)
2007-10-09 15:13 PDT, Geoffrey Garen 		ggaren: review+
Details | Formatted Diff | Diff
Patch4 (7.04 KB, patch)
2007-10-09 15:24 PDT, Geoffrey Garen 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2007-10-09 15:03:21 PDT 
Broken off from bug 14868.
Comment 1 Geoffrey Garen 2007-10-09 15:04:22 PDT 
Created attachment 16602 [details]
Patch
Comment 2 Darin Adler 2007-10-09 15:08:34 PDT 
Comment on attachment 16602 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2007-10-09 15:10:00 PDT 
Created attachment 16603 [details]
Patch2

Slightly updated test case and ChangeLog to reflect the full scope of this change.
Comment 4 Darin Adler 2007-10-09 15:10:49 PDT 
Comment on attachment 16603 [details]
Patch2

r=me
Comment 5 Geoffrey Garen 2007-10-09 15:13:28 PDT 
Created attachment 16604 [details]
Patch3

This one includes the updated layout test results, too. (I guess I'll r+ it myself.)
Comment 6 Geoffrey Garen 2007-10-09 15:24:56 PDT 
Created attachment 16605 [details]
Patch4

One more time with the right layout test results. This time for sure!
Comment 7 Geoffrey Garen 2007-10-15 13:54:10 PDT 
Committed revision 26621.