Bug 154406 - Web Inspector: CSS var() function should be syntax highlighted
Summary: Web Inspector: CSS var() function should be syntax highlighted
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
Keywords: InRadar
Depends on:
Reported: 2016-02-18 12:41 PST by Timothy Hatcher
Modified: 2016-02-19 15:56 PST (History)
8 users (show)

See Also:

[Patch] Proposed Fix (2.58 KB, patch)
2016-02-19 14:01 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-02-18 12:41:52 PST
The var() is black, while the text inside is highlighted correctly as a property now.
Comment 1 Radar WebKit Bug Importer 2016-02-18 12:42:16 PST
Comment 2 Matt Baker 2016-02-18 15:50:53 PST
"var" is in the valueKeywords_ array in External/CodeMirror/css.js, so it seems like it should just work. "calc" is in the same array, and appears correctly.
Comment 3 Timothy Hatcher 2016-02-18 16:15:09 PST
We replace CodeMirrors valueKeywords in WebInspector.CSSCompletions.requestCSSCompletions.
Comment 4 Matt Baker 2016-02-19 14:01:16 PST
Created attachment 271796 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-02-19 15:56:23 PST
Comment on attachment 271796 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 271796

Committed r196843: <http://trac.webkit.org/changeset/196843>
Comment 6 WebKit Commit Bot 2016-02-19 15:56:28 PST
All reviewed patches have been landed.  Closing bug.