RESOLVED FIXED 154406
Web Inspector: CSS var() function should be syntax highlighted
https://bugs.webkit.org/show_bug.cgi?id=154406
Summary Web Inspector: CSS var() function should be syntax highlighted
Timothy Hatcher
Reported 2016-02-18 12:41:52 PST
The var() is black, while the text inside is highlighted correctly as a property now.
Attachments
[Patch] Proposed Fix (2.58 KB, patch)
2016-02-19 14:01 PST, Matt Baker
no flags
Radar WebKit Bug Importer
Comment 1 2016-02-18 12:42:16 PST
Matt Baker
Comment 2 2016-02-18 15:50:53 PST
"var" is in the valueKeywords_ array in External/CodeMirror/css.js, so it seems like it should just work. "calc" is in the same array, and appears correctly.
Timothy Hatcher
Comment 3 2016-02-18 16:15:09 PST
We replace CodeMirrors valueKeywords in WebInspector.CSSCompletions.requestCSSCompletions.
Matt Baker
Comment 4 2016-02-19 14:01:16 PST
Created attachment 271796 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2016-02-19 15:56:23 PST
Comment on attachment 271796 [details] [Patch] Proposed Fix Clearing flags on attachment: 271796 Committed r196843: <http://trac.webkit.org/changeset/196843>
WebKit Commit Bot
Comment 6 2016-02-19 15:56:28 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.