Bug 154404 – Web Inspector: Styles Sidebar focus jumps when trying to edit a color

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

Created attachment 271680 [details]
Video of the Bug

Steps:
1) Inspect the Inspector
2) Click on a Rule near the top of the sidebar to give it keyboard focus
3) Scroll down to the variables section
4) Click to edit a color

Results: The fist click on the swatch fails sometimes with a small scroll jump. Subsequent clicks work, but when the color changes in the popover the sidebar jumps to the previous focus rule, closing the popover.
Expected: No scrolling and the color popover should stay open.

See attached video.

[Radar WebKit Bug Importer]

<rdar://problem/24725744>

[Timothy Hatcher]

I had a heck of a time recording the video for this Tweet because of this bug. https://twitter.com/webkit/status/700412341368844288

[Devin Rousso]

Created attachment 271725 [details]
Patch

[Devin Rousso]

Comment on attachment 271725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271725&action=review

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:1308
> +        if (this._delegate && typeof this._delegate.cssStyleDeclarationTextEditorBlurActiveEditor === "function")

So I'm not really sure that "cssStyleDeclarationTextEditorBlurActiveEditor" is the right name for this function as it really only drops the previously saved section, but "cssStyleDeclarationTextEditorClearActiveSection" or "cssStyleDeclarationTextEditorForgetPreviouslyActiveSection" sound a bit unwieldy and ridiculous.

[WebKit Commit Bot]

Comment on attachment 271725 [details]
Patch

Clearing flags on attachment: 271725

Committed r196798: <http://trac.webkit.org/changeset/196798>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.