Bug 154397 - Remove two unused functions
Summary: Remove two unused functions
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 154402
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-18 10:02 PST by Anders Carlsson
Modified: 2024-02-25 06:54 PST (History)
9 users (show)

See Also:


Attachments
Patch (2.90 KB, patch)
2016-02-18 10:03 PST, Anders Carlsson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-02-18 10:02:53 PST
Remove two unused functions
Comment 1 Anders Carlsson 2016-02-18 10:03:38 PST
Created attachment 271666 [details]
Patch
Comment 2 Anders Carlsson 2016-02-18 10:44:48 PST
Committed r196765: <http://trac.webkit.org/changeset/196765>
Comment 3 WebKit Commit Bot 2016-02-18 10:59:16 PST
Re-opened since this is blocked by bug 154402
Comment 4 Csaba Osztrogonác 2016-02-19 01:59:24 PST
(In reply to comment #2)
> Committed r196765: <http://trac.webkit.org/changeset/196765>

No, they aren't unused at all, as the EFL EWS noticed.

But of course, you have the right to break EFL build whenever 
you want, but in this case the title of the bug is incorrect.
Comment 5 Ahmad Saleem 2022-10-25 08:34:41 PDT
WKPluginSiteDataManager -> this was removed in below:

https://bugs.webkit.org/show_bug.cgi?id=154470 & Commit:

https://github.com/WebKit/WebKit/commit/a430103e139d9b5fa6fee8116ef572215fbbd4b7

WKResourceCacheManagerRef was changed into this and still present in Webkit:

https://github.com/WebKit/WebKit/commit/add72885f51729c2161735fabcda3f4af61d0d34

Do we need anything from this bug or we can mark this as "RESOLVED WONTFIX"? Thanks!
Comment 6 Ahmad Saleem 2024-02-24 15:36:40 PST
Can we do this clean-up?

https://github.com/WebKit/WebKit/blob/bcb2f892a5d1c79d21b6df3222186a81f014e059/Source/WebKit/UIProcess/API/C/WKContext.cpp#L437C27-L437C60

WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context)
{
    return reinterpret_cast<WKResourceCacheManagerRef>(WKWebsiteDataStoreGetDefaultDataStore());
}
Comment 7 Ahmad Saleem 2024-02-25 04:54:45 PST
@Michael & Diego - Is this used for WebKitGTK / WPE build?

https://github.com/WebKit/WebKit/blob/bcb2f892a5d1c79d21b6df3222186a81f014e059/Source/WebKit/UIProcess/API/C/WKContext.cpp#L437C27-L437C60

WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context)
{
    return reinterpret_cast<WKResourceCacheManagerRef>(WKWebsiteDataStoreGetDefaultDataStore());
}
Comment 8 Michael Catanzaro 2024-02-25 06:54:52 PST
It's clearly not used by anything:

$ git grep WKContextGetResourceCacheManager
WebKit/UIProcess/API/C/WKContext.cpp:WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context)
WebKit/UIProcess/API/C/WKContext.h:WK_EXPORT WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKWebsiteDataStoreGetDefaultDataStore);
WebKit/mac/WebKit2.order:_WKContextGetResourceCacheManager

I don't know what the rules are for removing old C APIs, though. I think these APIs are not public on any port? But we clearly still attempt to maintain API stability for some reason? If so, then I guess it stays.