Bug 154397 – Remove two unused functions

• Status: REOPENED
• Component: New Bugs

[Anders Carlsson]

Remove two unused functions

[Anders Carlsson]

Created attachment 271666 [details]
Patch

[Anders Carlsson]

Committed r196765: <http://trac.webkit.org/changeset/196765>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 154402

[Csaba Osztrogonác]

(In reply to comment #2)
> Committed r196765: <http://trac.webkit.org/changeset/196765>

No, they aren't unused at all, as the EFL EWS noticed.

But of course, you have the right to break EFL build whenever 
you want, but in this case the title of the bug is incorrect.

[Ahmad Saleem]

WKPluginSiteDataManager -> this was removed in below:

https://bugs.webkit.org/show_bug.cgi?id=154470 & Commit:

https://github.com/WebKit/WebKit/commit/a430103e139d9b5fa6fee8116ef572215fbbd4b7

WKResourceCacheManagerRef was changed into this and still present in Webkit:

https://github.com/WebKit/WebKit/commit/add72885f51729c2161735fabcda3f4af61d0d34

Do we need anything from this bug or we can mark this as "RESOLVED WONTFIX"? Thanks!

[Ahmad Saleem]

Can we do this clean-up?

https://github.com/WebKit/WebKit/blob/bcb2f892a5d1c79d21b6df3222186a81f014e059/Source/WebKit/UIProcess/API/C/WKContext.cpp#L437C27-L437C60

WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context)
{
    return reinterpret_cast<WKResourceCacheManagerRef>(WKWebsiteDataStoreGetDefaultDataStore());
}

[Ahmad Saleem]

@Michael & Diego - Is this used for WebKitGTK / WPE build?

https://github.com/WebKit/WebKit/blob/bcb2f892a5d1c79d21b6df3222186a81f014e059/Source/WebKit/UIProcess/API/C/WKContext.cpp#L437C27-L437C60

WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context)
{
    return reinterpret_cast<WKResourceCacheManagerRef>(WKWebsiteDataStoreGetDefaultDataStore());
}

[Michael Catanzaro]

It's clearly not used by anything:

$ git grep WKContextGetResourceCacheManager
WebKit/UIProcess/API/C/WKContext.cpp:WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context)
WebKit/UIProcess/API/C/WKContext.h:WK_EXPORT WKResourceCacheManagerRef WKContextGetResourceCacheManager(WKContextRef context) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKWebsiteDataStoreGetDefaultDataStore);
WebKit/mac/WebKit2.order:_WKContextGetResourceCacheManager

I don't know what the rules are for removing old C APIs, though. I think these APIs are not public on any port? But we clearly still attempt to maintain API stability for some reason? If so, then I guess it stays.