Bug 154386 – Replace ENABLE(B3_JIT) guards with ENABLE(FTL_JIT) after r196729

• Status: RESOLVED
• Resolution: WONTFIX
• Component: JavaScriptCore

[Csaba Osztrogonác]

http://trac.webkit.org/changeset/196729 remove all LLVM drops 
from WebKit trunk, now ENABLE(B3_JIT) guard is equal to ENABLE(FTL_JIT).

Let's use ENABLE(FTL_JIT) everywhere, we don't need this redundancy.

[Csaba Osztrogonác]

Created attachment 271642 [details]
Patch

[Filip Pizlo]

Comment on attachment 271642 [details]
Patch

We deliberately used a separate guard because we think that B3 will be useful even when FTL is disabled. It also makes bring up easier: you can enable just B3 in order to build and run its unit tests (testb3). 

Also we are getting a lot of requests about decoupling B3 from JavaScriptCore. We don't know if that's a good idea yet but let's not rule it out.

[Csaba Osztrogonác]

(In reply to comment #2)
> Comment on attachment 271642 [details]
> Patch
> 
> We deliberately used a separate guard because we think that B3 will be
> useful even when FTL is disabled. It also makes bring up easier: you can
> enable just B3 in order to build and run its unit tests (testb3). 

FTL builds, works fine. B3 builds, works fine. I don't understand 
why can be useful to disable FTL and enable only B3. Do you mean
if somebody would like to port B3-FTL to a brand new 64 bit platform?

> Also we are getting a lot of requests about decoupling B3 from
> JavaScriptCore. We don't know if that's a good idea yet but let's not rule
> it out.

It is much more clear and reasonable.

[Csaba Osztrogonác]

Comment on attachment 271642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271642&action=review

> Source/WTF/wtf/Platform.h:-773
> -/* This controls whether B3 is built. It will not be used unless FTL_USES_B3 is enabled. */

But in this case this comment is absolutely misleading. Filip, could you possibly correct it?

[Geoffrey Garen]

> Do you mean
> if somebody would like to port B3-FTL to a brand new 64 bit platform?

Yes, I think that's what he meant by "bring up".