Bug 154384 – Web Inspector: Option-clicking on the a CSS property sometimes doesn't work

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Exceptions:

[Error] Assertion Failed
	_associateRelatedProperties (DOMNodeStyles.js:906)
	_updateStyleCascade (DOMNodeStyles.js:796)
	fetchedInlineStyles (DOMNodeStyles.js:140)
	fetchedInlineStyles
	_dispatchResponseToCallback (InspectorBackend.js:297)
	_dispatchResponse (InspectorBackend.js:270)
	dispatch (InspectorBackend.js:149)
	dispatchNextQueuedMessageFromBackend (MessageDispatcher.js:42)

[Error] Assertion Failed
	tokenTrackingControllerHighlightedRangeWasClicked (CSSStyleDeclarationTextEditor.js:1631)
	_mouseButtonWasReleasedOverEditor (CodeMirrorTokenTrackingController.js:404:90)
	handleEvent (CodeMirrorTokenTrackingController.js:255)


This bug has been around for a long time,
it isn't a regression from Bug 154082.

[Radar WebKit Bug Importer]

<rdar://problem/24714755>

[Nikita Vasilyev]

Steps:
1. Open Elements tab
2. In the styles sidebar, select "Styles - Rules"
3. Select some element that has CSS rules
4. Option-click on a CSS property, Resources tab should open
5. Go back to Elements tab
6. Option-Click on the same property

Expected:
Resource tab opens again.

Actual:
Nothing happens. An exception is thrown.

Notes:
Option-clicking on a CSS variable, e.g. var(--border-color),
has the same problem.

[Nikita Vasilyev]

Devin, you're probably the best person to know
what's going on in there.

[Devin Rousso]

Created attachment 272308 [details]
Patch

[Nikita Vasilyev]

(In reply to comment #4)
> Created attachment 272308 [details]
> Patch

I can confirm this fixes the bug. Good job!

[WebKit Commit Bot]

Comment on attachment 272308 [details]
Patch

Clearing flags on attachment: 272308

Committed r197169: <http://trac.webkit.org/changeset/197169>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.