Bug 154365 - Rename FTLB3Blah to FTLBlah
Summary: Rename FTLB3Blah to FTLBlah
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-17 16:30 PST by Filip Pizlo
Modified: 2016-04-29 19:08 PDT (History)
2 users (show)

See Also:


Attachments
the patch (95.80 KB, patch)
2016-02-17 16:32 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the pqtch (97.91 KB, patch)
2016-02-17 16:37 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-17 16:30:51 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-17 16:31:18 PST
RS=ggaren, benjamin, and awesomekling.
Comment 2 Filip Pizlo 2016-02-17 16:32:26 PST
Created attachment 271604 [details]
the patch
Comment 3 WebKit Commit Bot 2016-02-17 16:34:04 PST
Attachment 271604 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:129:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:141:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:219:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:26:  #ifndef header guard has wrong style, please use: FTLOutput_h  [build/header_guard] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222:  The parameter name "pointer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223:  The parameter name "pointer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:529:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 12 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2016-02-17 16:37:23 PST
Created attachment 271605 [details]
the pqtch

fix buidl
Comment 5 WebKit Commit Bot 2016-02-17 16:38:56 PST
Attachment 271605 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:129:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:141:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.cpp:219:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:222:  The parameter name "pointer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:223:  The parameter name "pointer" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ftl/FTLOutput.h:529:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLCompile.cpp:130:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 10 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Joseph Pecoraro 2016-04-29 19:08:52 PDT
This landed: <https://trac.webkit.org/changeset/196731>