Bug 154357 - Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test
Summary: Regression(r196648): http://w3c-test.org/html/dom/interfaces.html redirects a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
: 125221 (view as bug list)
Depends on:
Blocks: 154120
  Show dependency tree / graph
 
Reported: 2016-02-17 13:52 PST by Chris Dumez
Modified: 2016-05-24 22:07 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.48 KB, patch)
2016-02-17 14:39 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-02-17 13:52:29 PST 
http://w3c-test.org/html/dom/interfaces.html redirects at the end of the test after <http://trac.webkit.org/changeset/196648>. Previously it did not redirect and it does not redirect either in other browsers.
It redirects to http://w3c-test.org/html/dom/undefined
Comment 1 Chris Dumez 2016-02-17 13:56:25 PST 
I think the problem is that our Location.assign() / Location.replace() should take a mandatory parameter but it is optional in WebKit. The test tries to call these operations without parameter to make sure it throws. However, in our case, it does NOT throw and it calls the function with the string "undefined" instead.
Comment 2 Chris Dumez 2016-02-17 14:39:34 PST 
Created attachment 271593 [details]
Patch
Comment 3 WebKit Commit Bot 2016-02-17 21:44:09 PST 
Comment on attachment 271593 [details]
Patch

Clearing flags on attachment: 271593

Committed r196742: <http://trac.webkit.org/changeset/196742>
Comment 4 WebKit Commit Bot 2016-02-17 21:44:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2016-05-24 22:07:42 PDT 
*** Bug 125221 has been marked as a duplicate of this bug. ***