Bug 154343 - [iOS] Purge GraphicsServices font cache on memory warning.
Summary: [iOS] Purge GraphicsServices font cache on memory warning.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on: 154371
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-17 10:53 PST by Andreas Kling
Modified: 2017-01-12 16:48 PST (History)
4 users (show)

See Also:

Attachments
Potch (2.18 KB, patch)
2016-02-17 10:54 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for landing (3.89 KB, patch)
2017-01-02 06:56 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for landing (3.89 KB, patch)
2017-01-12 11:52 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for landing (5.09 KB, patch)
2017-01-12 14:48 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-02-17 10:53:28 PST 
Platform objects for CSS fonts currently survive fake memory warnings due to the GS font cache retaining them.
Comment 1 Andreas Kling 2016-02-17 10:54:58 PST 
Created attachment 271565 [details]
Potch
Comment 2 WebKit Commit Bot 2016-02-17 12:27:55 PST 
Comment on attachment 271565 [details]
Potch

Clearing flags on attachment: 271565

Committed r196712: <http://trac.webkit.org/changeset/196712>
Comment 3 WebKit Commit Bot 2016-02-17 12:28:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2016-02-17 17:19:32 PST 
It looks like this change may have caused new API test failures on ios-simulator

<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/3185>

Tests that failed:
  WKUserContentController.AddUserStyleSheetAfterCreatingView
  WKUserContentController.AddUserStyleSheetBeforeCreatingView
  WebKit2.BundleParameters

Tests that timed out:
  WKWebView.LoadAlternateHTMLStringFromProvisionalLoadError
  WebKit2.RemoteObjectRegistry
Comment 5 Ryan Haddad 2016-02-17 17:35:27 PST 
I ran API tests with and without this change locally, and it does appear that it causes the failures.
Comment 6 WebKit Commit Bot 2016-02-17 18:00:25 PST 
Re-opened since this is blocked by bug 154371
Comment 7 Andreas Kling 2017-01-02 06:56:36 PST 
Created attachment 297897 [details]
Patch for landing
Comment 8 Andreas Kling 2017-01-12 11:52:04 PST 
Created attachment 298703 [details]
Patch for landing

Surprised that this doesn't link on iOS EWS. Trying a re-upload before diving deeper.
Comment 9 Andreas Kling 2017-01-12 14:48:13 PST 
Created attachment 298711 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2017-01-12 16:48:42 PST 
Comment on attachment 298711 [details]
Patch for landing

Clearing flags on attachment: 298711

Committed r210688: <http://trac.webkit.org/changeset/210688>
Comment 11 WebKit Commit Bot 2017-01-12 16:48:47 PST 
All reviewed patches have been landed.  Closing bug.