Now runtime/* sources and llint/* sources are added to JavaScriptCore_SOURCES unconditionally, but in a different place. Let's move them to the main list. And there is no need to add ftl/* sources conditionally to JavaScriptCore_SOURCES. FTL JIT is enabled almost everywhere and these files are guarded properly, no need to have a build system condition too.
Created attachment 271551 [details] Patch
Comment on attachment 271551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271551&action=review > Source/JavaScriptCore/CMakeLists.txt:-995 > -if (ENABLE_FTL_JIT) Personally I don't like to use guard in *.cmake though, I know win port doesn't enable FTL JIT yet. It looks there are still people to use guard in cmake files.
(In reply to comment #2) > Comment on attachment 271551 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271551&action=review > > > Source/JavaScriptCore/CMakeLists.txt:-995 > > -if (ENABLE_FTL_JIT) > > Personally I don't like to use guard in *.cmake though, I know win port > doesn't enable FTL JIT yet. It looks there are still people to use guard in > cmake files. As I said, FTL JIT files are guarded properly, there is no reason to duplicate these guards in the build system too. It is a common design in WebKit, that we add source files unconditionally in the build system. FTL JIT shouldn't be an exception.
Created attachment 271643 [details] Patch updated to ToT
Created attachment 271644 [details] Patch really updated to ToT
Comment on attachment 271644 [details] Patch The GTK+ CQ is a bit overflown, I'll ping the appropriate people. I don't think this should cause build problems as it is, though.
Comment on attachment 271644 [details] Patch Clearing flags on attachment: 271644 Committed r196752: <http://trac.webkit.org/changeset/196752>
All reviewed patches have been landed. Closing bug.