Bug 154334 - JSDOMWindow::put should not do the same thing twice in different ways
Summary: JSDOMWindow::put should not do the same thing twice in different ways
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-17 00:59 PST by Gavin Barraclough
Modified: 2016-02-17 11:26 PST (History)
5 users (show)

See Also:


Attachments
Fix (4.66 KB, patch)
2016-02-17 01:04 PST, Gavin Barraclough
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2016-02-17 00:59:19 PST
It either calls JSGlobalObject::put or Base::put. Hint: these are basically the same thing. In the latter case it might call lookupPut. That's redundant; JSObject::put handles static table entries.
Comment 1 Gavin Barraclough 2016-02-17 01:04:34 PST
Created attachment 271547 [details]
Fix
Comment 2 Gavin Barraclough 2016-02-17 01:05:15 PST
All red patch! Whoooo!
Comment 3 Chris Dumez 2016-02-17 08:45:37 PST
Comment on attachment 271547 [details]
Fix

r=me
Comment 4 Gavin Barraclough 2016-02-17 11:26:37 PST
Transmitting file data ....
Committed revision 196702.