Improve accessibility text navigation. Change the sentence related text marker calls to use TextIterator.
<rdar://problem/24269658>
Created attachment 271497 [details] patch
Comment on attachment 271497 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=271497&action=review looks ok > Source/WebCore/accessibility/AXObjectCache.cpp:1741 > + if (charOffset.offset == offset) do we have a test case covering this now? > Source/WebCore/accessibility/AXObjectCache.cpp:2122 > + // We don't want to go to the previous node. can you add why > Source/WebCore/accessibility/AXObjectCache.cpp:2193 > + if (!next.isNull() && next.node->hasTagName(brTag) && !characterOffset.node->hasTagName(brTag)) can you put this if into a static method. looks like you use it here and below > Source/WebCore/accessibility/AXObjectCache.cpp:2230 > + // make sure we move off of a sentence end full sentence
Comment on attachment 271497 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=271497&action=review >> Source/WebCore/accessibility/AXObjectCache.cpp:1741 >> + if (charOffset.offset == offset) > > do we have a test case covering this now? Yes, it's covered in the sentence navigation. >> Source/WebCore/accessibility/AXObjectCache.cpp:2122 >> + // We don't want to go to the previous node. > > can you add why Ok. >> Source/WebCore/accessibility/AXObjectCache.cpp:2193 >> + if (!next.isNull() && next.node->hasTagName(brTag) && !characterOffset.node->hasTagName(brTag)) > > can you put this if into a static method. looks like you use it here and below Ok. >> Source/WebCore/accessibility/AXObjectCache.cpp:2230 >> + // make sure we move off of a sentence end > > full sentence Ok.
Created attachment 271545 [details] patch
Comment on attachment 271545 [details] patch Clearing flags on attachment: 271545 Committed r196699: <http://trac.webkit.org/changeset/196699>
All reviewed patches have been landed. Closing bug.