Add tests for iframe and overflow scrollability after navigating back
Created attachment 271452 [details] Patch
Created attachment 271458 [details] Patch
Comment on attachment 271458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271458&action=review r=me, but please consider only checking for "changed" rather than specific scroll position numbers. > LayoutTests/fast/scrolling/iframe-scrollable-after-back.html:35 > + logResult('Scrolled; scrollTop is ' + document.getElementById('iframe').contentDocument.scrollingElement.scrollTop); This might be flaky on different machines (e.g., with different scroll precision). You might just confirm that the scrollTop changed from whatever value you see at the start of the test.
(In reply to comment #3) > Comment on attachment 271458 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271458&action=review > > r=me, but please consider only checking for "changed" rather than specific > scroll position numbers. > > > LayoutTests/fast/scrolling/iframe-scrollable-after-back.html:35 > > + logResult('Scrolled; scrollTop is ' + document.getElementById('iframe').contentDocument.scrollingElement.scrollTop); > > This might be flaky on different machines (e.g., with different scroll > precision). You might just confirm that the scrollTop changed from whatever > value you see at the start of the test. If it is, that's a problem with the test harness.
Comment on attachment 271458 [details] Patch Attachment 271458 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/841496 New failing tests: fast/scrolling/overflow-scrollable-after-back.html fast/scrolling/iframe-scrollable-after-back.html
Created attachment 271469 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 271458 [details] Patch Attachment 271458 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/841508 New failing tests: fast/scrolling/overflow-scrollable-after-back.html fast/scrolling/iframe-scrollable-after-back.html
Created attachment 271471 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
https://trac.webkit.org/r196665
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 271458 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=271458&action=review > > > > r=me, but please consider only checking for "changed" rather than specific > > scroll position numbers. > > > > > LayoutTests/fast/scrolling/iframe-scrollable-after-back.html:35 > > > + logResult('Scrolled; scrollTop is ' + document.getElementById('iframe').contentDocument.scrollingElement.scrollTop); > > > > This might be flaky on different machines (e.g., with different scroll > > precision). You might just confirm that the scrollTop changed from whatever > > value you see at the start of the test. > > If it is, that's a problem with the test harness. Ermmmm (from test failures): Sending wheel event; scrollTop is 0 -Scrolled; scrollTop is 20 +Scrolled; scrollTop is 28
I skipped on WK1 when landing.
(In reply to comment #10) > (In reply to comment #4) > > (In reply to comment #3) > > > Comment on attachment 271458 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=271458&action=review > > > > > > r=me, but please consider only checking for "changed" rather than specific > > > scroll position numbers. > > > > > > > LayoutTests/fast/scrolling/iframe-scrollable-after-back.html:35 > > > > + logResult('Scrolled; scrollTop is ' + document.getElementById('iframe').contentDocument.scrollingElement.scrollTop); > > > > > > This might be flaky on different machines (e.g., with different scroll > > > precision). You might just confirm that the scrollTop changed from whatever > > > value you see at the start of the test. > > > > If it is, that's a problem with the test harness. > > Ermmmm (from test failures): > > Sending wheel event; scrollTop is 0 > -Scrolled; scrollTop is 20 > +Scrolled; scrollTop is 28 Similar failures in GTK+ where minimum scroll is 40.
I'll fix the tests.
(In reply to comment #13) > I'll fix the tests. Thanks!, I also think that just checking that the view did actually scroll should be enough as Brent suggested, how much it scrolled doesn't really matter in this test.
Tests fixed in https://trac.webkit.org/r196719