Bug 154292 - AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts
Summary: AX: Change "dialog" role description to "web dialog" so users can distinguish...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Safari 9
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-16 10:48 PST by James Craig
Modified: 2016-06-19 09:57 PDT (History)
11 users (show)

See Also:

Attachments
patch (3.82 KB, patch)
2016-03-22 10:58 PDT, Nan Wang 		cfleizach: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2016-02-16 10:48:23 PST 
AX: Change "dialog" role description to "web dialog" so users can distinguish from native alerts
Comment 1 Radar WebKit Bug Importer 2016-02-16 10:53:55 PST 
<rdar://problem/24679586>
Comment 2 James Craig 2016-02-17 14:55:04 PST 
Potentially need to do something separate for alert dialogs: "alert dialog (web)", "alert web dialog", "web alert dialog", or just "web alert"?
Comment 3 Nan Wang 2016-03-22 10:58:05 PDT 
Created attachment 274663 [details]
patch
Comment 4 Nan Wang 2016-03-22 12:19:06 PDT 
https://trac.webkit.org/changeset/198543
Comment 5 mitz 2016-06-19 09:57:22 PDT 
The strings file is automatically generated from source using update-webkit-localizable-strings, so the right fix for this is to change LocalizedStrings.cpp. Otherwise, the values will revert the next time the strings file is regenerated.

I am going to include the change to LocalizedStrings.cpp in an upcoming patch, though.