Bug 154291 - [CSS Grid Layout Refactoring some layout tests
Summary: [CSS Grid Layout Refactoring some layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-16 10:13 PST by Javier Fernandez
Modified: 2016-02-19 05:25 PST (History)
6 users (show)

See Also:

Attachments
Patch (354.71 KB, patch)
2016-02-16 11:15 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2016-02-16 10:13:08 PST 
There are several tests using specific CSS rules with different sizing values, like fit-content, fill-content, ... In order to deal with different prefix and evaluate the browser interoperability we need to refactor some of the grid layout tests so they use shared CSS classes.
Comment 1 Javier Fernandez 2016-02-16 11:15:05 PST 
Created attachment 271446 [details]
Patch
Comment 2 Sergio Villar Senin 2016-02-19 03:08:47 PST 
Comment on attachment 271446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271446&action=review

Nice changes.

> LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html:28
> +    height: calc(70% + 30%);

Didn't know that this was already unprefixed in WebKit.

> LayoutTests/fast/css-grid-layout/resources/grid.css:313
>      -webkit-writing-mode: vertical-rl;

Why do we need prefixed and unprefixed?

> LayoutTests/fast/css-grid-layout/resources/grid.css:316
> +    writing-mode: vertical-lr;

Ditto.

> LayoutTests/fast/css-grid-layout/resources/grid.css:321
> +    -webkit-writing-mode: horizontal-tb;

Ditto.

> LayoutTests/fast/css-grid-layout/resources/grid.css:325
>      -webkit-writing-mode: horizontal-bt;

Ditto.
Comment 3 Javier Fernandez 2016-02-19 04:36:53 PST 
(In reply to comment #2)
> Comment on attachment 271446 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=271446&action=review
> 
> Nice changes.
> 
> > LayoutTests/fast/css-grid-layout/calc-resolution-grid-item.html:28
> > +    height: calc(70% + 30%);
> 
> Didn't know that this was already unprefixed in WebKit.

It is, as far as I know.

> 
> > LayoutTests/fast/css-grid-layout/resources/grid.css:313
> >      -webkit-writing-mode: vertical-rl;
> 
> Why do we need prefixed and unprefixed?

The purpose of this patch is to ease the execution of the tests in different browsers. WebKit still has prefix for this CSS property, while Blink and Firefox don't 

> 
> > LayoutTests/fast/css-grid-layout/resources/grid.css:316
> > +    writing-mode: vertical-lr;
> 
> Ditto.

Replied.

> 
> > LayoutTests/fast/css-grid-layout/resources/grid.css:321
> > +    -webkit-writing-mode: horizontal-tb;
> 
> Ditto.
> 

Replied.

> > LayoutTests/fast/css-grid-layout/resources/grid.css:325
> >      -webkit-writing-mode: horizontal-bt;
> 
> Ditto.

Replied.
Comment 4 WebKit Commit Bot 2016-02-19 05:25:50 PST 
Comment on attachment 271446 [details]
Patch

Clearing flags on attachment: 271446

Committed r196819: <http://trac.webkit.org/changeset/196819>
Comment 5 WebKit Commit Bot 2016-02-19 05:25:53 PST 
All reviewed patches have been landed.  Closing bug.