Bug 154277 - Extract the code specific to v2 UI out of shared statistics.js
Summary: Extract the code specific to v2 UI out of shared statistics.js
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-15 20:39 PST by Ryosuke Niwa
Modified: 2016-02-16 15:16 PST (History)
5 users (show)

See Also:

Attachments
Cleanup (34.67 KB, patch)
2016-02-15 20:54 PST, Ryosuke Niwa 		cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-02-15 20:39:42 PST 
Extract the code specific to v2 UI (and the current implementation of detect-changes.js) out of statistics.js

This re-factoring is needed to support statistical tools in v3 UI.
Comment 1 Ryosuke Niwa 2016-02-15 20:54:18 PST 
Created attachment 271412 [details]
Cleanup
Comment 2 Chris Dumez 2016-02-16 13:39:15 PST 
Comment on attachment 271412 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=271412&action=review

rs=me

> Websites/perf.webkit.org/ChangeLog:8
> +        Extracted statistics-strategies.js out of statistics.js for v2 UI and detect-changes.js. The indent is to

"intent" ?

> Websites/perf.webkit.org/public/shared/statistics.js:136
> +    this.cumultaiveMovingAverage = function (values) {

"cumulative".

> Websites/perf.webkit.org/public/v2/statistics-strategies.js:21
> +        execute: Statistics.cumultaiveMovingAverage,

"cumulative"
Comment 3 Ryosuke Niwa 2016-02-16 15:16:21 PST 
Committed r196663: <http://trac.webkit.org/changeset/196663>