Bug 154268 - FTL should support NewTypedArray
Summary: FTL should support NewTypedArray
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 154315
Blocks: 132356
  Show dependency treegraph
 
Reported: 2016-02-15 16:56 PST by Filip Pizlo
Modified: 2016-02-16 20:26 PST (History)
6 users (show)

See Also:


Attachments
the patch (6.15 KB, patch)
2016-02-16 13:05 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff
the patch (6.22 KB, patch)
2016-02-16 18:34 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
even better patch (6.99 KB, patch)
2016-02-16 19:10 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-15 16:56:12 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-16 13:05:24 PST
Created attachment 271475 [details]
the patch
Comment 2 Filip Pizlo 2016-02-16 13:12:22 PST
Landed in http://trac.webkit.org/changeset/196652
Comment 3 WebKit Commit Bot 2016-02-16 15:43:45 PST
Re-opened since this is blocked by bug 154315
Comment 4 Filip Pizlo 2016-02-16 18:13:40 PST
(In reply to comment #3)
> Re-opened since this is blocked by bug 154315

LOL, I realize why.  I passed the typed array storage as a butterfly.  That ain't right.
Comment 5 Filip Pizlo 2016-02-16 18:34:26 PST
Created attachment 271516 [details]
the patch

This time, it won't set the bots on fire, I promise.
Comment 6 Filip Pizlo 2016-02-16 19:10:04 PST
Created attachment 271519 [details]
even better patch
Comment 7 Filip Pizlo 2016-02-16 20:26:19 PST
Landed in http://trac.webkit.org/changeset/196684