RESOLVED FIXED 154267
FTL should support StringFromCharCode 
https://bugs.webkit.org/show_bug.cgi?id=154267
Summary FTL should support StringFromCharCode
Filip Pizlo
Reported 2016-02-15 16:55:37 PST
Patch forthcoming.
Attachments
the patch (9.61 KB, patch)
2016-02-15 16:58 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
initial performance report (65.84 KB, text/plain)
2016-02-16 11:10 PST, Filip Pizlo 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-02-15 16:58:29 PST
Created attachment 271391 [details] the patch
Mark Lam
Comment 2 2016-02-15 17:02:12 PST
Comment on attachment 271391 [details] the patch Do you have perf numbers?
Mark Lam
Comment 3 2016-02-15 17:08:44 PST
Comment on attachment 271391 [details] the patch r=me if perf numbers are good.
Mark Lam
Comment 4 2016-02-16 09:36:52 PST
*** Bug 153069 has been marked as a duplicate of this bug. ***
Filip Pizlo
Comment 5 2016-02-16 09:59:36 PST
(In reply to comment #3) > Comment on attachment 271391 [details] > the patch > > r=me if perf numbers are good. Thanks! I'm going to run them now.
Mark Lam
Comment 6 2016-02-16 10:10:20 PST
<rdar://problem/24192536>
Filip Pizlo
Comment 7 2016-02-16 11:10:25 PST
Created attachment 271442 [details] initial performance report
Filip Pizlo
Comment 8 2016-02-16 11:11:04 PST
Because string-from-char-code.js ran for much shorter than I wanted, I made it run 10x longer, and reran just those benchmarks. Results: TipOfTree FromCharCode string-from-char-code 16.8306+-0.6567 ^ 6.7301+-0.4895 ^ definitely 2.5008x faster untyped-string-from-char-code 17.6565+-0.5887 ^ 10.9026+-2.4457 ^ definitely 1.6195x faster <geometric> 17.2385+-0.6145 ^ 8.5458+-0.8659 ^ definitely 2.0172x faster It's pretty cool that even in the untyped case, the FTL provides a significant win.
Filip Pizlo
Comment 9 2016-02-16 11:36:23 PST
Landed in http://trac.webkit.org/changeset/196642
Note You need to log in before you can comment on or make changes to this bug.