Bug 154255 - stress/sampling-profiler-deep-stack.js fails on ARM 32bit
Summary: stress/sampling-profiler-deep-stack.js fails on ARM 32bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-15 13:42 PST by Saam Barati
Modified: 2016-02-16 12:51 PST (History)
11 users (show)

See Also:


Attachments
patch (1.54 KB, patch)
2016-02-16 12:35 PST, Saam Barati
mark.lam: review+
sbarati: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-02-15 13:42:10 PST
...
Comment 1 Radar WebKit Bug Importer 2016-02-15 14:15:48 PST
<rdar://problem/24662996>
Comment 2 Saam Barati 2016-02-16 12:35:07 PST
Created attachment 271468 [details]
patch
Comment 3 Mark Lam 2016-02-16 12:43:26 PST
Comment on attachment 271468 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271468&action=review

r=me with improved comment.

> Source/JavaScriptCore/ChangeLog:12
> +        The DFG was doing a good job at optimizing the function
> +        at the leaf of the recursion. Because of that, we often
> +        wouldn't sample it. I fixed this by making the leaf
> +        function do more work.

It's not clear from this comment that this test failure does not reflect a bug in the VM.  Instead, it is the test that is not set up to meet its own expectations.  Hence, the fix requires that the test be modified.  Can you update the comment to say something to that effect?
Comment 4 Saam Barati 2016-02-16 12:51:05 PST
landed fix in:
https://trac.webkit.org/changeset/196650