For debugging purposes, it would be handy to disable this.
<rdar://problem/24662616>
<rdar://problem/24662620>
Created attachment 271566 [details] Patch
Comment on attachment 271566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271566&action=review So this impacts the freeing of memory when the process gets suspended as well. Is it intentional? This is not technically memory pressure even though we use more or less the same code for both cases. > Source/WebKit/mac/ChangeLog:23 > + In actuality, only the WebContent and Network processes heed the flag. How about the UIProcess? See for example on iOS: /Volumes/Data/WebKit/OpenSource/Source/WebKit2/UIProcess/ios/WebMemoryPressureHandlerIOS.mm It does not seem to be impacted by your patch but it probably should.
(In reply to comment #4) > Comment on attachment 271566 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=271566&action=review > > So this impacts the freeing of memory when the process gets suspended as > well. Is it intentional? This is not technically memory pressure even though > we use more or less the same code for both cases. > Apparently it is alright. But then, we also want to do it in the WebProcess suspension case as well: see MemoryPressureHandler::singleton().releaseMemory(Critical::Yes, Synchronous::Yes); calls in WebProcess.cpp.
> How about the UIProcess? See for example on iOS: > /Volumes/Data/WebKit/OpenSource/Source/WebKit2/UIProcess/ios/WebMemoryPressureHandlerIOS.mm I've added a check in that function and updated the check-in comment. >> So this impacts the freeing of memory when the process gets suspended as >> well. Is it intentional? This is not technically memory pressure even though >> we use more or less the same code for both cases. > Apparently it is alright. But then, we also want to do it in the WebProcess > suspension case as well: see > MemoryPressureHandler::singleton().releaseMemory(Critical::Yes, Synchronous::Yes); calls in WebProcess.cpp. I've added a check here, too.
Created attachment 271688 [details] Patch
Comment on attachment 271688 [details] Patch r=me
Comment on attachment 271688 [details] Patch Clearing flags on attachment: 271688 Committed r196943: <http://trac.webkit.org/changeset/196943>
All reviewed patches have been landed. Closing bug.