Bug 154248 - Null-deref crash in DefaultAudioDestinationNode::suspend()
Summary: Null-deref crash in DefaultAudioDestinationNode::suspend()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-15 11:00 PST by Jer Noble
Modified: 2016-02-15 14:39 PST (History)
2 users (show)

See Also:


Attachments
Patch (106.04 KB, patch)
2016-02-15 11:03 PST, Jer Noble
achristensen: review+
mcatanzaro: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-02-15 11:00:01 PST
Null-deref crash in DefaultAudioDestinationNode::suspend()
Comment 1 Jer Noble 2016-02-15 11:00:31 PST
rdar://problem/21478816
Comment 2 Jer Noble 2016-02-15 11:03:25 PST
Created attachment 271349 [details]
Patch
Comment 3 WebKit Commit Bot 2016-02-15 11:06:03 PST
Attachment 271349 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webaudio/AudioContext.h:401:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/webaudio/AudioContext.h:405:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 61 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Alex Christensen 2016-02-15 13:16:13 PST
Comment on attachment 271349 [details]
Patch

That's quite a patch for adding 3 null checks.  r=me
Comment 5 Michael Catanzaro 2016-02-15 13:44:45 PST
Comment on attachment 271349 [details]
Patch

*Please* split this nice change into two patches before committing, it makes it unnecessarily hard to see the real fix.
Comment 6 Jer Noble 2016-02-15 14:35:35 PST
(In reply to comment #5)
> Comment on attachment 271349 [details]
> Patch
> 
> *Please* split this nice change into two patches before committing, it makes
> it unnecessarily hard to see the real fix.

Sure thing. I'll commit in two steps.
Comment 7 Jer Noble 2016-02-15 14:38:56 PST
Committed r196602: <http://trac.webkit.org/changeset/196602>
Comment 8 Jer Noble 2016-02-15 14:39:19 PST
Committed r196603: <http://trac.webkit.org/changeset/196603>