Bug 154238 - Drop StyleResolver and SelectorQueryCache when entering PageCache.
Summary: Drop StyleResolver and SelectorQueryCache when entering PageCache.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2016-02-15 03:23 PST by Andreas Kling
Modified: 2016-10-20 09:41 PDT (History)
8 users (show)

See Also:


Attachments
Patch (10.71 KB, patch)
2016-02-15 03:24 PST, Andreas Kling
koivisto: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (771.96 KB, application/zip)
2016-02-15 04:16 PST, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (838.66 KB, application/zip)
2016-02-15 04:33 PST, Build Bot
no flags Details
Patch for landing (13.75 KB, patch)
2016-02-15 10:44 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (12.50 KB, patch)
2016-02-16 00:40 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (13.27 KB, patch)
2016-10-20 08:53 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-02-15 03:23:54 PST
There are no brakes on the memory savings train!
Comment 1 Andreas Kling 2016-02-15 03:24:54 PST
Created attachment 271335 [details]
Patch
Comment 2 Build Bot 2016-02-15 04:16:43 PST
Comment on attachment 271335 [details]
Patch

Attachment 271335 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/834916

New failing tests:
compositing/iframes/page-cache-layer-tree.html
Comment 3 Build Bot 2016-02-15 04:16:47 PST
Created attachment 271337 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-02-15 04:33:39 PST
Comment on attachment 271335 [details]
Patch

Attachment 271335 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/834929

New failing tests:
compositing/iframes/page-cache-layer-tree.html
Comment 5 Build Bot 2016-02-15 04:33:42 PST
Created attachment 271338 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Andreas Kling 2016-02-15 10:44:26 PST
Created attachment 271348 [details]
Patch for landing
Comment 7 Andreas Kling 2016-02-16 00:40:05 PST
Created attachment 271420 [details]
Patch
Comment 8 WebKit Commit Bot 2016-02-16 02:00:15 PST
Comment on attachment 271420 [details]
Patch

Clearing flags on attachment: 271420

Committed r196633: <http://trac.webkit.org/changeset/196633>
Comment 9 WebKit Commit Bot 2016-02-16 02:00:19 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Chris Dumez 2016-06-03 13:58:58 PDT
Rolled out in <http://trac.webkit.org/changeset/201655> because it broke PageCache on iOS for WebKit.org, see <rdar://problem/26521101>.
Comment 11 Andreas Kling 2016-10-20 08:53:14 PDT
Created attachment 292200 [details]
Patch
Comment 12 WebKit Commit Bot 2016-10-20 09:41:35 PDT
Comment on attachment 292200 [details]
Patch

Clearing flags on attachment: 292200

Committed r207620: <http://trac.webkit.org/changeset/207620>
Comment 13 WebKit Commit Bot 2016-10-20 09:41:40 PDT
All reviewed patches have been landed.  Closing bug.