Bug 154237 – Web Inspector: Visual sidebar minor regression fixes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Each one of these issues is minor by themselves, so I figured that they could be merged into a single bug.  Here are the problems:
- r194728 <https://bugs.webkit.org/show_bug.cgi?id=152755>: Used Visual sidebar default unit lists by reference (not copying them), meaning that any modifications resulted in all future uses of that list to have said modifications.
- r196266 <https://bugs.webkit.org/show_bug.cgi?id=153890>: Visual sidebar comma separated value lists to no update their width's when the width of the sidebar is changed.
- r196266 <https://bugs.webkit.org/show_bug.cgi?id=153890>: Placeholder items in Visual sidebar comma separated value lists are prepended with "-"
- Modifying values after closing sections with values for the selected rule (which were automatically opened) causes those closed sections to reopen and the scroll position to shift
- Visual sidebar comma separated value lists do not hide the placeholder element used for the computed value of the property.

[Radar WebKit Bug Importer]

<rdar://problem/24653135>

[Devin Rousso]

Created attachment 271334 [details]
Patch

[Timothy Hatcher]

Comment on attachment 271334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271334&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:118
> +    widthDidChange()
> +    {

This needs to call super.widthDidChange().

[Devin Rousso]

Created attachment 271385 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 271385 [details]
Patch

Clearing flags on attachment: 271385

Committed r196610: <http://trac.webkit.org/changeset/196610>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.