Bug 154237 - Web Inspector: Visual sidebar minor regression fixes
Summary: Web Inspector: Visual sidebar minor regression fixes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Reported: 2016-02-15 03:16 PST by Devin Rousso
Modified: 2016-02-15 16:50 PST (History)
8 users (show)

See Also:

Patch (6.60 KB, patch)
2016-02-15 03:22 PST, Devin Rousso
timothy: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Patch (6.47 KB, patch)
2016-02-15 15:51 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-02-15 03:16:33 PST
Each one of these issues is minor by themselves, so I figured that they could be merged into a single bug.  Here are the problems:
- r194728 <https://bugs.webkit.org/show_bug.cgi?id=152755>: Used Visual sidebar default unit lists by reference (not copying them), meaning that any modifications resulted in all future uses of that list to have said modifications.
- r196266 <https://bugs.webkit.org/show_bug.cgi?id=153890>: Visual sidebar comma separated value lists to no update their width's when the width of the sidebar is changed.
- r196266 <https://bugs.webkit.org/show_bug.cgi?id=153890>: Placeholder items in Visual sidebar comma separated value lists are prepended with "-"
- Modifying values after closing sections with values for the selected rule (which were automatically opened) causes those closed sections to reopen and the scroll position to shift
- Visual sidebar comma separated value lists do not hide the placeholder element used for the computed value of the property.
Comment 1 Radar WebKit Bug Importer 2016-02-15 03:16:47 PST
Comment 2 Devin Rousso 2016-02-15 03:22:31 PST
Created attachment 271334 [details]
Comment 3 Timothy Hatcher 2016-02-15 13:27:41 PST
Comment on attachment 271334 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=271334&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:118
> +    widthDidChange()
> +    {

This needs to call super.widthDidChange().
Comment 4 Devin Rousso 2016-02-15 15:51:02 PST
Created attachment 271385 [details]
Comment 5 WebKit Commit Bot 2016-02-15 16:50:21 PST
Comment on attachment 271385 [details]

Clearing flags on attachment: 271385

Committed r196610: <http://trac.webkit.org/changeset/196610>
Comment 6 WebKit Commit Bot 2016-02-15 16:50:24 PST
All reviewed patches have been landed.  Closing bug.