Bug 154231 - Refactor LazyEventListener creation to separate Element and Document cases
Summary: Refactor LazyEventListener creation to separate Element and Document cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-14 19:18 PST by Darin Adler
Modified: 2016-02-21 18:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (18.39 KB, patch)
2016-02-14 19:25 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (497.73 KB, application/zip)
2016-02-14 20:08 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (301.13 KB, application/zip)
2016-02-14 20:11 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (380.61 KB, application/zip)
2016-02-14 20:15 PST, Build Bot 		no flags Details
Patch (18.52 KB, patch)
2016-02-20 20:24 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (19.59 KB, patch)
2016-02-21 16:31 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-02-14 19:18:33 PST 
Refactor LazyEventListener creation to separate Element and Document cases
Comment 1 Darin Adler 2016-02-14 19:25:28 PST 
Created attachment 271318 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-14 19:28:02 PST 
Attachment 271318 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2016-02-14 20:08:55 PST 
Comment on attachment 271318 [details]
Patch

Attachment 271318 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/833262

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2016-02-14 20:08:57 PST 
Created attachment 271321 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-02-14 20:11:29 PST 
Comment on attachment 271318 [details]
Patch

Attachment 271318 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/833267

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-02-14 20:11:31 PST 
Created attachment 271322 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-02-14 20:15:11 PST 
Comment on attachment 271318 [details]
Patch

Attachment 271318 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/833259

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2016-02-14 20:15:14 PST 
Created attachment 271324 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Darin Adler 2016-02-20 20:24:14 PST 
Created attachment 271873 [details]
Patch
Comment 10 Michael Catanzaro 2016-02-21 08:30:49 PST 
Probably need to forward-declare KeyboardEvent in Source\WebKit\win\WebView.h.
Comment 11 Darin Adler 2016-02-21 16:31:31 PST 
Created attachment 271892 [details]
Patch
Comment 12 Andreas Kling 2016-02-21 17:40:08 PST 
Comment on attachment 271892 [details]
Patch

r=me
Comment 13 WebKit Commit Bot 2016-02-21 18:33:26 PST 
Comment on attachment 271892 [details]
Patch

Clearing flags on attachment: 271892

Committed r196888: <http://trac.webkit.org/changeset/196888>
Comment 14 WebKit Commit Bot 2016-02-21 18:33:30 PST 
All reviewed patches have been landed.  Closing bug.