Bug 154230 - XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
Summary: XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://xhr.spec.whatwg.org/#xmlhttpr...
Keywords: WebExposed
Depends on: 154171
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-14 18:33 PST by Chris Dumez
Modified: 2016-02-15 14:03 PST (History)
6 users (show)

See Also:


Attachments
WIP Patch (19.10 KB, patch)
2016-02-14 21:55 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (44.17 KB, patch)
2016-02-14 22:18 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-02-14 18:33:30 PST
XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
Comment 1 Chris Dumez 2016-02-14 19:58:46 PST
Both Firefox and Chrome implement XMLHttpRequestEventTarget and expose it on the global Window object.
Comment 2 Chris Dumez 2016-02-14 21:55:28 PST
Created attachment 271325 [details]
WIP Patch
Comment 3 WebKit Commit Bot 2016-02-14 21:57:47 PST
Attachment 271325 [details] did not pass style-queue:


ERROR: Source/WebCore/xml/XMLHttpRequestEventTarget.h:34:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2016-02-14 22:18:57 PST
Created attachment 271326 [details]
Patch
Comment 5 Alex Christensen 2016-02-15 13:08:43 PST
Comment on attachment 271326 [details]
Patch

r=me.  As I've been glancing at the XHR spec, I've wondered why we didn't have this and couldn't think of a good reason other than "nobody's done it yet".
Comment 6 WebKit Commit Bot 2016-02-15 14:03:04 PST
Comment on attachment 271326 [details]
Patch

Clearing flags on attachment: 271326

Committed r196599: <http://trac.webkit.org/changeset/196599>
Comment 7 WebKit Commit Bot 2016-02-15 14:03:07 PST
All reviewed patches have been landed.  Closing bug.