Bug 154228 - The result ValueRep shouldn't be in params[0]. StackmapGenerationParams should have a separate field for it.
Summary: The result ValueRep shouldn't be in params[0]. StackmapGenerationParams shou...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-14 16:05 PST by Filip Pizlo
Modified: 2016-02-14 21:36 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-14 16:05:49 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-14 16:06:04 PST 
(In reply to comment #0)
> Patch forthcoming.

I didn't mean to say that.  I'm not working on this right now.
Comment 2 Saam Barati 2016-02-14 17:49:21 PST 
Sweet. I was thinking that this would be a good change to make.
Comment 3 Filip Pizlo 2016-02-14 18:06:13 PST 
(In reply to comment #2)
> Sweet. I was thinking that this would be a good change to make.

Do you want to volunteer? :-)))
Comment 4 Saam Barati 2016-02-14 21:31:07 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > Sweet. I was thinking that this would be a good change to make.
> 
> Do you want to volunteer? :-)))
I guess this is the last time I say I think a patch is a good idea ;)
I'm joking. Sure, I'll do it.
Comment 5 Filip Pizlo 2016-02-14 21:36:54 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Sweet. I was thinking that this would be a good change to make.
> > 
> > Do you want to volunteer? :-)))
> I guess this is the last time I say I think a patch is a good idea ;)
> I'm joking. Sure, I'll do it.

It's not a major priority either way, but it could be a fun clean-up. :-)