Bug 154219 – [cmake] Consolidated Linux-specific file lists.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Konstantin Tokarev]

Consolidated Linux-specific file lists.

[Konstantin Tokarev]

Created attachment 271297 [details]
Patch

[Michael Catanzaro]

Comment on attachment 271297 [details]
Patch

I am having second thoughts about putting the files in the top-level Platform directory. That is a really messy directory; it's going to be hard to find them.

Could these files be placed e.g. under platform/linux instead?

[Konstantin Tokarev]

1. I think that these files should be put either (a) into one directory, or (b) each of them should be placed where its sources are located. Solution (b) does not work for GStreamer, and it won't work for things like Cairo, so we need to choose one directory.

2. I had the same concerns about clutter in WebCore/platform as you do. In https://bugs.webkit.org/attachment.cgi?id=270993&action=review I've put ImageDecoders.cmake into WebCore root, but Alex disagreed. 

3. platform/linux is acceptable only for Linux.cmake, and certainly not for other components, since they are cross-platform or at least not specific to Linux.

[Gyuyoung Kim]

(In reply to comment #3)
> 1. I think that these files should be put either (a) into one directory, or
> (b) each of them should be placed where its sources are located. Solution
> (b) does not work for GStreamer, and it won't work for things like Cairo, so
> we need to choose one directory.
> 
> 2. I had the same concerns about clutter in WebCore/platform as you do. In
> https://bugs.webkit.org/attachment.cgi?id=270993&action=review I've put
> ImageDecoders.cmake into WebCore root, but Alex disagreed. 
> 
> 3. platform/linux is acceptable only for Linux.cmake, and certainly not for
> other components, since they are cross-platform or at least not specific to
> Linux.

I also like to put Linux.cmake into platform/linux in order not to messy webCore/platform directory.

[Michael Catanzaro]

Comment on attachment 271297 [details]
Patch

Thinking about this some more, I've come to think alternative solutions are worse; having all the CMake files under platform live in the top-level platform directory seems easiest.

[WebKit Commit Bot]

Comment on attachment 271297 [details]
Patch

Clearing flags on attachment: 271297

Committed r196578: <http://trac.webkit.org/changeset/196578>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.