Bug 154218 - Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width
Summary: Web Inspector: Sidebars are defaulting to their minimum width, instead of a g...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-13 10:37 PST by Timothy Hatcher
Modified: 2016-02-15 13:30 PST (History)
8 users (show)

See Also:


Attachments
Screenshot of the Bug (79.73 KB, image/png)
2016-02-13 10:37 PST, Timothy Hatcher
no flags Details
Expected Default Width (88.95 KB, image/png)
2016-02-13 10:38 PST, Timothy Hatcher
no flags Details
Patch (1.72 KB, patch)
2016-02-13 17:15 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2016-02-15 13:20 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-02-13 10:37:55 PST
Created attachment 271289 [details]
Screenshot of the Bug

I keep having skinny sidebars, which at at their minimum width. They use to default to a good visual width instead. I suspect this regressed from the changes to calculate the minimum width based on the navigation bars.
Comment 1 Radar WebKit Bug Importer 2016-02-13 10:38:09 PST
<rdar://problem/24644192>
Comment 2 Timothy Hatcher 2016-02-13 10:38:11 PST
Created attachment 271290 [details]
Expected Default Width
Comment 3 Timothy Hatcher 2016-02-13 17:15:36 PST
Created attachment 271302 [details]
Patch
Comment 4 Devin Rousso 2016-02-13 17:18:53 PST
Comment on attachment 271302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271302&action=review

> Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js:36
> +        this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 300);

NIT: Would it be better to put this as something similar to what "WebInspector.Sidebar.AbsoluteMinimumWidth" has?  Maybe "WebInspector.Sidebar.InitialWidth = 300;"?
Comment 5 Timothy Hatcher 2016-02-15 13:20:01 PST
Created attachment 271364 [details]
Patch
Comment 6 Timothy Hatcher 2016-02-15 13:20:48 PST
Ugh, wrong bug webkit-patch!
Comment 7 Timothy Hatcher 2016-02-15 13:24:56 PST
Comment on attachment 271302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271302&action=review

>> Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js:36
>> +        this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 300);
> 
> NIT: Would it be better to put this as something similar to what "WebInspector.Sidebar.AbsoluteMinimumWidth" has?  Maybe "WebInspector.Sidebar.InitialWidth = 300;"?

Most other settings have the default value inline. If we needed it else where, I would agree.
Comment 8 Joseph Pecoraro 2016-02-15 13:25:34 PST
Comment on attachment 271302 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2016-02-15 13:30:01 PST
Comment on attachment 271302 [details]
Patch

Clearing flags on attachment: 271302

Committed r196596: <http://trac.webkit.org/changeset/196596>
Comment 10 WebKit Commit Bot 2016-02-15 13:30:03 PST
All reviewed patches have been landed.  Closing bug.