Bug 154157 - Table border radius is not applied when the border color is transparent or semitransparent
Summary: Table border radius is not applied when the border color is transparent or se...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: Safari 9
Hardware: Mac OS X 10.11
: P2 Minor
Assignee: Fujii Hironori
URL:
Keywords: InRadar
: 171244 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-02-12 00:29 PST by Alan Sprecacenere
Modified: 2022-07-22 13:14 PDT (History)
14 users (show)

See Also:

Attachments
Test case (995 bytes, text/html)
2016-02-12 00:29 PST, Alan Sprecacenere 		no flags Details
Patch (4.50 KB, patch)
2022-07-14 21:43 PDT, Fujii Hironori 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP patch (3.02 KB, patch)
2022-07-20 17:54 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (4.38 KB, patch)
2022-07-21 23:30 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Sprecacenere 2016-02-12 00:29:04 PST 
Created attachment 271141 [details]
Test case

Using a transparent or a semitransparent border color on a table prevents the border radius to be applied.
I found this while styling a Dojo SelectBox widget, which uses a table as the root node.

Test case attached.
Comment 1 Simon Fraser (smfr) 2017-05-05 10:27:14 PDT 
Dup of bug 171244?
Comment 2 Alan Sprecacenere 2017-05-08 00:13:30 PDT 
It looks like so.
Comment 3 Simon Fraser (smfr) 2017-05-08 10:17:59 PDT 
*** Bug 171244 has been marked as a duplicate of this bug. ***
Comment 4 Brent Fulgham 2022-07-14 15:21:04 PDT 
This continues to be a bug in Safari 15.5+
Comment 5 Radar WebKit Bug Importer 2022-07-14 15:21:15 PDT 
<rdar://problem/97038189>
Comment 6 Fujii Hironori 2022-07-14 21:43:22 PDT 
Created attachment 460922 [details]
Patch
Comment 7 Simon Fraser (smfr) 2022-07-15 09:23:16 PDT 
Comment on attachment 460922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460922&action=review

> Source/WebCore/rendering/RenderTable.cpp:-803
> -    if (style().hasVisibleBorderDecoration() && !collapseBorders())
> -        paintBorder(paintInfo, rect, style());

Do these lines do anything special compared to the base class implementation? Do we have a test that hits this case?
Comment 8 Fujii Hironori 2022-07-18 18:10:06 PDT 
Comment on attachment 460922 [details]
Patch

Yes, it does. Some old pixel tests covered. I should add a ref test.
Comment 9 Fujii Hironori 2022-07-20 17:54:31 PDT 
Created attachment 461064 [details]
WIP patch
Comment 10 Fujii Hironori 2022-07-21 23:30:20 PDT 
Created attachment 461132 [details]
Patch
Comment 11 EWS 2022-07-22 13:14:11 PDT 
Committed 252741@main (96f929df42d3): <https://commits.webkit.org/252741@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461132 [details].