Bug 154150 - Web Inspector: SourceCodeTextEditor close() generates removeEventListener warnings
Summary: Web Inspector: SourceCodeTextEditor close() generates removeEventListener war...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-02-11 19:51 PST by Joseph Pecoraro
Modified: 2016-02-11 21:17 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.18 KB, patch)
2016-02-11 19:52 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-02-11 19:51:16 PST 
* SUMMARY
SourceCodeTextEditor close() generates removeEventListener warnings:

Resources/Base/Object.js:97:23: CONSOLE ERROR removeEventListener cannot remove issue-manager-issue-was-added because it doesn't exist.
Resources/Base/Object.js:97:23: CONSOLE ERROR removeEventListener cannot remove source-code-source-map-added because it doesn't exist.

* STEPS TO REPRODUCE
1. Inspect this page
2. Open a bunch of scripts
3. Reload
  => warnings

* NOTES
- We should only removeEventListener if we directly added an event listener. We know that pretty easily here.
Comment 1 Joseph Pecoraro 2016-02-11 19:52:40 PST 
Created attachment 271124 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2016-02-11 21:17:12 PST 
Comment on attachment 271124 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 271124

Committed r196464: <http://trac.webkit.org/changeset/196464>
Comment 3 WebKit Commit Bot 2016-02-11 21:17:15 PST 
All reviewed patches have been landed.  Closing bug.