Bug 154143 – [ES6] we have an incorrect syntax error when a callee of a function expression has the same name as a top-level lexical declaration

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

```
(function foo() { const foo = 20; });
```
is a syntax error but it shouldn't be.

[Saam Barati]

Created attachment 271113 [details]
patch

[Build Bot]

Comment on attachment 271113 [details]
patch

Attachment 271113 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/817189

New failing tests:
streams/pipe-to.html
streams/reference-implementation/pipe-through.html
streams/brand-checks.html
streams/reference-implementation/pipe-to-options.html

[Build Bot]

Created attachment 271121 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 271113 [details]
patch

Attachment 271113 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/817196

New failing tests:
streams/pipe-to.html
streams/reference-implementation/pipe-through.html
streams/brand-checks.html
streams/reference-implementation/readable-stream-templated.html
streams/reference-implementation/pipe-to-options.html

[Build Bot]

Created attachment 271123 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 271113 [details]
patch

Attachment 271113 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/817334

New failing tests:
streams/pipe-to.html
streams/reference-implementation/pipe-through.html
streams/brand-checks.html
streams/reference-implementation/readable-stream-templated.html
streams/reference-implementation/pipe-to-options.html

[Build Bot]

Created attachment 271125 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Saam Barati]

Created attachment 271259 [details]
for landing

[WebKit Commit Bot]

Comment on attachment 271259 [details]
for landing

Clearing flags on attachment: 271259

Committed r196545: <http://trac.webkit.org/changeset/196545>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.