Bug 154121 - [Web IDL] interfaces should inherit EventTarget instead of duplicating the EventTarget API
Summary: [Web IDL] interfaces should inherit EventTarget instead of duplicating the Ev...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
: 67329 (view as bug list)
Depends on:
Blocks: 154170
  Show dependency tree / graph
 
Reported: 2016-02-11 12:08 PST by Chris Dumez
Modified: 2021-03-17 04:46 PDT (History)
12 users (show)

See Also:

Attachments
WIP Patch (65.71 KB, patch)
2016-02-11 13:57 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (99.78 KB, patch)
2016-02-11 14:52 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (99.90 KB, patch)
2016-02-11 15:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (101.25 KB, patch)
2016-02-11 16:05 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (100.04 KB, patch)
2016-02-11 16:15 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (100.32 KB, patch)
2016-02-11 16:23 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (100.39 KB, patch)
2016-02-11 16:31 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (100.61 KB, patch)
2016-02-11 18:43 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (108.92 KB, patch)
2016-02-11 20:23 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (108.89 KB, patch)
2016-02-11 20:30 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-02-11 12:08:25 PST 
interfaces should inherit EventTarget instead of duplicating the EventTarget API in their IDL.

We should also be able to get rid of the [EventTarget] WebKit IDL attribute in a follow-up.
Comment 1 Radar WebKit Bug Importer 2016-02-11 12:14:31 PST 
<rdar://problem/24613234>
Comment 2 Chris Dumez 2016-02-11 13:57:28 PST 
Created attachment 271083 [details]
WIP Patch
Comment 3 Chris Dumez 2016-02-11 14:52:00 PST 
Created attachment 271094 [details]
WIP Patch
Comment 4 Chris Dumez 2016-02-11 15:37:29 PST 
Created attachment 271098 [details]
WIP Patch
Comment 5 Chris Dumez 2016-02-11 16:05:35 PST 
Created attachment 271099 [details]
WIP Patch
Comment 6 Chris Dumez 2016-02-11 16:14:40 PST 
Struggling a bit to get the GObject bindings right.
Comment 7 Chris Dumez 2016-02-11 16:15:05 PST 
Created attachment 271100 [details]
WIP Patch
Comment 8 Chris Dumez 2016-02-11 16:23:29 PST 
Created attachment 271101 [details]
WIP Patch
Comment 9 Chris Dumez 2016-02-11 16:31:52 PST 
Created attachment 271105 [details]
WIP Patch
Comment 10 Chris Dumez 2016-02-11 18:43:37 PST 
Created attachment 271116 [details]
WIP Patch
Comment 11 Chris Dumez 2016-02-11 20:23:34 PST 
Created attachment 271126 [details]
Patch
Comment 12 Chris Dumez 2016-02-11 20:30:34 PST 
Created attachment 271127 [details]
Patch
Comment 13 WebKit Commit Bot 2016-02-11 23:28:35 PST 
Comment on attachment 271127 [details]
Patch

Clearing flags on attachment: 271127

Committed r196466: <http://trac.webkit.org/changeset/196466>
Comment 14 WebKit Commit Bot 2016-02-11 23:28:41 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 Darin Adler 2016-02-12 08:41:47 PST 
Comment on attachment 271127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review

I love this patch. One tiny thing in it that I find irritating is the argument name "domObject"; I probably would have suggested "wrappableObject" instead, since I like words much better than acronyms and jargon.

> Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:32
> +] interface SpeechSynthesisUtterance : EventTarget
> +{

Small editing mistake: Why add this new line break in just this one file?
Comment 16 Darin Adler 2016-02-12 08:42:38 PST 
Comment on attachment 271127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review

> Source/WebCore/dom/WebKitNamedFlow.idl:37
> +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +: EventTarget
> +#endif

Elsewhere we indented lines like the EventTarget one here.
Comment 17 Chris Dumez 2016-02-12 08:44:57 PST 
Comment on attachment 271127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review

>> Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:32
>> +{
> 
> Small editing mistake: Why add this new line break in just this one file?

Yes indeed, I'll fix it now. Thanks.

>> Source/WebCore/dom/WebKitNamedFlow.idl:37
>> +#endif
> 
> Elsewhere we indented lines like the EventTarget one here.

Actually, I was supposed to drop the #ifdefing. I'll do that.
Comment 18 Chris Dumez 2016-02-12 08:49:19 PST 
Updated as per Darin's feedback in <http://trac.webkit.org/changeset/196476>.
Comment 19 Alexey Shvayka 2021-03-17 04:46:18 PDT 
*** Bug 67329 has been marked as a duplicate of this bug. ***