Bug 154121 – [Web IDL] interfaces should inherit EventTarget instead of duplicating the EventTarget API

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

interfaces should inherit EventTarget instead of duplicating the EventTarget API in their IDL.

We should also be able to get rid of the [EventTarget] WebKit IDL attribute in a follow-up.

[Radar WebKit Bug Importer]

<rdar://problem/24613234>

[Chris Dumez]

Created attachment 271083 [details]
WIP Patch

[Chris Dumez]

Created attachment 271094 [details]
WIP Patch

[Chris Dumez]

Created attachment 271098 [details]
WIP Patch

[Chris Dumez]

Created attachment 271099 [details]
WIP Patch

[Chris Dumez]

Struggling a bit to get the GObject bindings right.

[Chris Dumez]

Created attachment 271100 [details]
WIP Patch

[Chris Dumez]

Created attachment 271101 [details]
WIP Patch

[Chris Dumez]

Created attachment 271105 [details]
WIP Patch

[Chris Dumez]

Created attachment 271116 [details]
WIP Patch

[Chris Dumez]

Created attachment 271126 [details]
Patch

[Chris Dumez]

Created attachment 271127 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 271127 [details]
Patch

Clearing flags on attachment: 271127

Committed r196466: <http://trac.webkit.org/changeset/196466>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 271127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review

I love this patch. One tiny thing in it that I find irritating is the argument name "domObject"; I probably would have suggested "wrappableObject" instead, since I like words much better than acronyms and jargon.

> Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:32
> +] interface SpeechSynthesisUtterance : EventTarget
> +{

Small editing mistake: Why add this new line break in just this one file?

[Darin Adler]

Comment on attachment 271127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review

> Source/WebCore/dom/WebKitNamedFlow.idl:37
> +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +: EventTarget
> +#endif

Elsewhere we indented lines like the EventTarget one here.

[Chris Dumez]

Comment on attachment 271127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271127&action=review

>> Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl:32
>> +{
> 
> Small editing mistake: Why add this new line break in just this one file?

Yes indeed, I'll fix it now. Thanks.

>> Source/WebCore/dom/WebKitNamedFlow.idl:37
>> +#endif
> 
> Elsewhere we indented lines like the EventTarget one here.

Actually, I was supposed to drop the #ifdefing. I'll do that.

[Chris Dumez]

Updated as per Darin's feedback in <http://trac.webkit.org/changeset/196476>.

[Alexey Shvayka]

*** Bug 67329 has been marked as a duplicate of this bug. ***