RESOLVED FIXED 154116
[cmake] Consolidate building of GStreamer and OpenWebRTC code. 
https://bugs.webkit.org/show_bug.cgi?id=154116
Summary [cmake] Consolidate building of GStreamer and OpenWebRTC code.
Konstantin Tokarev
Reported 2016-02-11 10:24:37 PST
Eleminated large duplication between GTK and Efl.
Attachments
Patch (15.55 KB, patch)
2016-02-11 10:27 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (15.58 KB, patch)
2016-02-11 11:59 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (15.72 KB, patch)
2016-02-12 09:55 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (15.72 KB, patch)
2016-02-12 10:00 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (15.56 KB, patch)
2016-02-13 08:11 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-02-11 10:27:01 PST
Created attachment 271063 [details] Patch
Konstantin Tokarev
Comment 2 2016-02-11 11:59:59 PST
Created attachment 271071 [details] Patch
Alex Christensen
Comment 3 2016-02-11 20:35:03 PST
Comment on attachment 271071 [details] Patch I think OpenWebRTC and GStreamer are separate enough to be in different platform files. One could, theoretically use OpenWebRTC without GStreamer
Philippe Normand
Comment 4 2016-02-12 03:22:57 PST
(In reply to comment #3) > Comment on attachment 271071 [details] > Patch > > I think OpenWebRTC and GStreamer are separate enough to be in different > platform files. One could, theoretically use OpenWebRTC without GStreamer I don't see how this could work because currently OpenWebRTC internally depends on GStreamer anyway.
Michael Catanzaro
Comment 5 2016-02-12 07:46:37 PST
Comment on attachment 271071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271071&action=review Seems like this is indeed the best place for OpenWebRTC, then. > Source/WebCore/platform/GStreamer.cmake:5 > +list(APPEND WebCore_SOURCES I think you can conditionally append these files to WebCore_SOURCES in the ENABLE_VIDEO OR ENABLE_WEB_AUDIO condition below; then in a follow-up we could remove the preprocessor guards from the files.
Konstantin Tokarev
Comment 6 2016-02-12 09:55:50 PST
Created attachment 271180 [details] Patch
Konstantin Tokarev
Comment 7 2016-02-12 10:00:36 PST
Created attachment 271182 [details] Patch
Konstantin Tokarev
Comment 8 2016-02-13 08:11:58 PST
Created attachment 271283 [details] Patch
Konstantin Tokarev
Comment 9 2016-02-13 08:14:17 PST
ImageGStreamerCairo.cpp should go to Cairo.cmake under if(USE_GSTREAMER), not to GStreamer.cmake.
WebKit Commit Bot
Comment 10 2016-02-13 11:12:29 PST
Comment on attachment 271283 [details] Patch Clearing flags on attachment: 271283 Committed r196552: <http://trac.webkit.org/changeset/196552>
WebKit Commit Bot
Comment 11 2016-02-13 11:12:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.