WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
REOPENED
154115
[GTK] HTTP auth dialog layout broken with GTK+ 3.19
https://bugs.webkit.org/show_bug.cgi?id=154115
Summary
[GTK] HTTP auth dialog layout broken with GTK+ 3.19
Michael Catanzaro
Reported
2016-02-11 10:17:48 PST
The layout and padding on the HTTP auth dialog is quite broken. And somehow the action buttons (authenticate, cancel) have swapped positions.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2016-02-12 01:44:06 PST
It seems the layout and paddings are much better now with GTK+ from current master, but the buttons are still in the wrong order
Carlos Garcia Campos
Comment 2
2016-02-12 02:50:49 PST
Comment hidden (obsolete)
There are two problems here, first we are changing the cairo operator when rendering the xcomposite window pixmap without a proper save/restore, so it affects the drawing that happens after that, and second problem is tyhat we are not rendering the gray background in AC mode. I'll submit a patch.
Carlos Garcia Campos
Comment 3
2016-02-12 02:55:17 PST
Comment hidden (obsolete)
Oops commented in the wrong bug, sorry.
Carlos Garcia Campos
Comment 4
2016-02-12 04:34:25 PST
So the only problem was the buttons ordering and it was a GTK+ regression introduced in
https://git.gnome.org/browse/gtk+/commit/?id=572e9a04027e213082a5b257e5d662a5daa32667
that I have just reverted in
https://git.gnome.org/browse/gtk+/commit/?id=170cb016759c4a949c7cd81291da498395f18fb3
so I'm closing this as invalid since it's not our bug.
Michael Catanzaro
Comment 5
2016-02-12 07:56:55 PST
I just built GTK+ master and I see zero padding between the Remember Password and the Cancel/Authenticate buttons.
Michael Catanzaro
Comment 6
2016-02-12 08:13:05 PST
Hm, it depends on the length of the domain....
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug