Bug 154115 - [GTK] HTTP auth dialog layout broken with GTK+ 3.19
Summary: [GTK] HTTP auth dialog layout broken with GTK+ 3.19
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-11 10:17 PST by Michael Catanzaro
Modified: 2016-02-12 08:13 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-02-11 10:17:48 PST
The layout and padding on the HTTP auth dialog is quite broken.

And somehow the action buttons (authenticate, cancel) have swapped positions.
Comment 1 Carlos Garcia Campos 2016-02-12 01:44:06 PST
It seems the layout and paddings are much better now with GTK+ from current master, but the buttons are still in the wrong order
Comment 2 Carlos Garcia Campos 2016-02-12 02:50:49 PST
There are two problems here, first we are changing the cairo operator when rendering the xcomposite window pixmap without a proper save/restore, so it affects the drawing that happens after that, and second problem is tyhat we are not rendering the gray background in AC mode. I'll submit a patch.
Comment 3 Carlos Garcia Campos 2016-02-12 02:55:17 PST
Oops commented in the wrong bug, sorry.
Comment 4 Carlos Garcia Campos 2016-02-12 04:34:25 PST
So the only problem was the buttons ordering and it was a GTK+ regression introduced in https://git.gnome.org/browse/gtk+/commit/?id=572e9a04027e213082a5b257e5d662a5daa32667 that I have just reverted in https://git.gnome.org/browse/gtk+/commit/?id=170cb016759c4a949c7cd81291da498395f18fb3 so I'm closing this as invalid since it's not our bug.
Comment 5 Michael Catanzaro 2016-02-12 07:56:55 PST
I just built GTK+ master and I see zero padding between the Remember Password and the Cancel/Authenticate buttons.
Comment 6 Michael Catanzaro 2016-02-12 08:13:05 PST
Hm, it depends on the length of the domain....