"Own"
Created attachment 271049 [details] Patch for EWS
Comment on attachment 271049 [details] Patch for EWS Attachment 271049 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/813426 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html http/tests/security/window-named-valueOf.html fast/dom/Window/es52-globals.html
Created attachment 271051 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 271049 [details] Patch for EWS Attachment 271049 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/813434 New failing tests: imported/w3c/web-platform-tests/html/dom/interfaces.html http/tests/security/window-named-valueOf.html fast/dom/Window/es52-globals.html
Created attachment 271052 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 271049 [details] Patch for EWS Attachment 271049 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/813420 New failing tests: http/tests/security/window-named-valueOf.html fast/dom/Window/es52-globals.html
Created attachment 271053 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 271494 [details] Fix
Comment on attachment 271494 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271494&action=review > Source/JavaScriptCore/runtime/JSObject.cpp:-2555 > - // JSDOMWindow::getOwnPropertySlot() may return attributes from the prototype chain but getOwnPropertyDescriptor() Nice that we can get rid of this hack. > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:199 > + if (proto.isObject() && asObject(proto)->getPropertySlot(exec, propertyName, prototypeSlot)) Why don't we use asObject(proto)->hasProperty(exec, propertyName) ? This is what our generated bindings are doing and it avoids having to construct a slot.
Comment on attachment 271494 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=271494&action=review > Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:195 > // FIXME: If the property is present on the prototype we should 'return false;', not We should also drop this FIXME :o)
Comment on attachment 271494 [details] Fix You also apparently need to check imported/w3c/web-platform-tests/html/dom/interfaces.html as it is failing on ews.
Created attachment 271511 [details] Updated patch
Comment on attachment 271511 [details] Updated patch Nice, r=me!
Transmitting file data ........ Committed revision 196676.
What is the photo chain?
Comment on attachment 271511 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=271511&action=review > Source/JavaScriptCore/runtime/JSObject.cpp:-2555 > - // JSDOMWindow::getOwnPropertySlot() may return attributes from the prototype chain but getOwnPropertyDescriptor() Looks like this may have caused Bug 154378. As it turns out, JSDOMWindow::getOwnPropertySlot() is not the only one returning attributes from the prototype chain, so does DebuggerScope::getOwnPropertySlot() :/