Bug 154099 – Focus rings around text fields do not follow contour (border-radius)

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

outline: auto painting (focusring) should follow the curve of border-radius.

[alan]

Created attachment 271930 [details]
WIP

[alan]

Created attachment 271932 [details]
outline-offset: 20px

[alan]

Created attachment 271933 [details]
Outline-offset: 3px

[alan]

Created attachment 271934 [details]
outline-offset: 10px -multiline

[Tim Horton]

Comment on attachment 271930 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=271930&action=review

> Source/WebCore/platform/graphics/PathUtilities.cpp:394
> +    static const float gCircleControlPoint = 0.447715f;

g :| This should probably mention where it came from. Or, even better, expose it on Path. Or something.

[alan]

Created attachment 273790 [details]
Patch

[Tim Horton]

Comment on attachment 273790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273790&action=review

> Source/WebCore/platform/graphics/PathUtilities.h:40
> +    static Path pathWithShrinkWrappedRectsForOutline(const Vector<FloatRect>&, const BorderData&, float outlineOffset, bool leftToRightWritingMode, bool horizontalWritingMode);

Do we not have nice enums for the bools?

> LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html:8
> + 	color: RGBA(0, 0, 0, 0);

I think people usually write rgba() not RGBA()

> LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html:18
> +    outline-offset: 0px;

Twice?

> LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html:19
> +    outline-offset: 0px;

Again

> LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html:25
> +    border-radius: 15px 4px 8px 5px;

Indentation is broken here

> LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html:8
> + 	font-size: 20px;

Indentation again?

[alan]

Created attachment 273836 [details]
Patch

[alan]

rdar://problem/9988429

[alan]

(In reply to comment #7)
> Comment on attachment 273790 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273790&action=review
> 
> > Source/WebCore/platform/graphics/PathUtilities.h:40
> > +    static Path pathWithShrinkWrappedRectsForOutline(const Vector<FloatRect>&, const BorderData&, float outlineOffset, bool leftToRightWritingMode, bool horizontalWritingMode);
> 
> Do we not have nice enums for the bools?
> 
> > LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html:8
> > + 	color: RGBA(0, 0, 0, 0);
> 
> I think people usually write rgba() not RGBA()
> 
> > LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-horizontal-ltr.html:18
> > +    outline-offset: 0px;
> 
> Twice?
> 
> > LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html:19
> > +    outline-offset: 0px;
> 
> Again
> 
> > LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-vertical-ltr.html:25
> > +    border-radius: 15px 4px 8px 5px;
> 
> Indentation is broken here
> 
> > LayoutTests/fast/inline/hidpi-outline-auto-with-border-radius-vertical-rtl.html:8
> > + 	font-size: 20px;
> 
> Indentation again?
Done.

[alan]

*** Bug 69195 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 273836 [details]
Patch

Clearing flags on attachment: 273836

Committed r198062: <http://trac.webkit.org/changeset/198062>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.