Bug 154089 - Web Inspector: Add new icon for the Timeline Recording navigation bar item
Summary: Web Inspector: Add new icon for the Timeline Recording navigation bar item
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks: 154088
  Show dependency tree / graph
 
Reported: 2016-02-10 14:23 PST by Timothy Hatcher
Modified: 2016-02-10 16:52 PST (History)
9 users (show)

See Also:

Attachments
Screenshot (26.55 KB, image/png)
2016-02-10 14:24 PST, Timothy Hatcher 		no flags Details
Patch (13.75 KB, patch)
2016-02-10 14:28 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
[Image] Watch w/ one button (85.86 KB, image/png)
2016-02-10 14:40 PST, Matt Baker 		no flags Details
[Image] Two-up: original vs. one button (92.80 KB, image/png)
2016-02-10 14:45 PST, Matt Baker 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2016-02-10 14:23:17 PST 
This icon was still a bitmap after all the others are now vector.
Comment 1 Timothy Hatcher 2016-02-10 14:24:06 PST 
Created attachment 271028 [details]
Screenshot
Comment 2 Radar WebKit Bug Importer 2016-02-10 14:24:25 PST 
<rdar://problem/24595652>
Comment 3 Timothy Hatcher 2016-02-10 14:28:51 PST 
Created attachment 271030 [details]
Patch
Comment 4 Matt Baker 2016-02-10 14:39:44 PST 
Very nice!
Comment 5 Matt Baker 2016-02-10 14:40:49 PST 
Created attachment 271031 [details]
[Image] Watch w/ one button

Does having three buttons feel too busy at small sizes? Attached is a mockup of the same icon, with just a single button.
Comment 6 Matt Baker 2016-02-10 14:45:27 PST 
Created attachment 271032 [details]
[Image] Two-up: original vs. one button

For comparison
Comment 7 Timothy Hatcher 2016-02-10 14:47:35 PST 
The extra buttons is more accurate, since our stopwatch has two arms (a lap arm), which is traditionally controlled by a button, along with reset and start/stop button.
Comment 8 Timothy Hatcher 2016-02-10 14:48:12 PST 
It looks fine on retina, and Jon assures me it is good on 1x displays too. (Jon made the icon.)
Comment 9 Matt Baker 2016-02-10 14:51:59 PST 
(In reply to comment #8)
> It looks fine on retina, and Jon assures me it is good on 1x displays too.
> (Jon made the icon.)

Ok, sounds good!
Comment 10 BJ Burg 2016-02-10 16:02:40 PST 
Comment on attachment 271030 [details]
Patch

rs=me
Comment 11 WebKit Commit Bot 2016-02-10 16:52:31 PST 
Comment on attachment 271030 [details]
Patch

Clearing flags on attachment: 271030

Committed r196406: <http://trac.webkit.org/changeset/196406>
Comment 12 WebKit Commit Bot 2016-02-10 16:52:34 PST 
All reviewed patches have been landed.  Closing bug.