RESOLVED FIXED154084
Update "manual" caption track logic 
https://bugs.webkit.org/show_bug.cgi?id=154084
Summary Update "manual" caption track logic
Eric Carlson
Reported 2016-02-10 13:34:10 PST
When manual selection mode is enabled: + don't change 'forced' track kind to 'caption' + forced tracks should include “forced” in their caption menu title + no tracks should be enabled by default
Attachments
Proposed patch. (17.79 KB, patch)
2016-02-10 14:23 PST, Eric Carlson 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2016-02-10 13:34:41 PST
<rdar://problem/24530516>
Radar WebKit Bug Importer
Comment 2 2016-02-10 13:41:14 PST
<rdar://problem/24594371>
Eric Carlson
Comment 3 2016-02-10 14:23:59 PST
Created attachment 271027 [details] Proposed patch.
Dean Jackson
Comment 4 2016-02-10 15:01:40 PST
Comment on attachment 271027 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=271027&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3872 > + if (trackToEnable) > + m_subtitleTrackLanguage = trackToEnable->language(); > + else > + m_subtitleTrackLanguage = emptyString(); I never know which we prefer: m_subtitleTrackLanguage = trackToEnable ? trackToEnable->language() : emptyString();
Eric Carlson
Comment 5 2016-02-10 16:11:34 PST
Committed r196401: https://trac.webkit.org/r196401
Note You need to log in before you can comment on or make changes to this bug.