Bug 154084 - Update "manual" caption track logic
Summary: Update "manual" caption track logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-10 13:34 PST by Eric Carlson
Modified: 2016-02-10 16:11 PST (History)
1 user (show)

See Also:

Attachments
Proposed patch. (17.79 KB, patch)
2016-02-10 14:23 PST, Eric Carlson 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-02-10 13:34:10 PST 
When manual selection mode is enabled:

 + don't change 'forced' track kind to 'caption'
 + forced tracks should include “forced” in their caption menu title
 + no tracks should be enabled by default
Comment 1 Eric Carlson 2016-02-10 13:34:41 PST 
<rdar://problem/24530516>
Comment 2 Radar WebKit Bug Importer 2016-02-10 13:41:14 PST 
<rdar://problem/24594371>
Comment 3 Eric Carlson 2016-02-10 14:23:59 PST 
Created attachment 271027 [details]
Proposed patch.
Comment 4 Dean Jackson 2016-02-10 15:01:40 PST 
Comment on attachment 271027 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=271027&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3872
> +        if (trackToEnable)
> +            m_subtitleTrackLanguage = trackToEnable->language();
> +        else
> +            m_subtitleTrackLanguage = emptyString();

I never know which we prefer: m_subtitleTrackLanguage = trackToEnable ? trackToEnable->language() : emptyString();
Comment 5 Eric Carlson 2016-02-10 16:11:34 PST 
Committed r196401: https://trac.webkit.org/r196401